[CORE-4855] During inheritance return type should be compatible - Blesta

Details

Type: Sub-task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 5.8.0-b1
Component/s: None
Labels:
None

Description

Error:

During inheritance return type should be compatible

Affected Files:

/vendors/blesta/items/src/Collection/ItemCollection.php (Line 65)
/vendors/blesta/pricing/src/Collection/ItemPriceCollection.php (Line 298)

Possible solution:
Add the "#[\ReturnTypeWillChange]" attribute to all the methods of the affected classes.

Activity

Ascending order - Click to sort in descending order

Abdy Franco created issue - 28/Mar/23 6:28 PM

Abdy Franco made changes - 28/Mar/23 6:28 PM

Field	Original Value	New Value
Fix Version/s		5.7.0-b1 [ 11737 ]

Abdy Franco made changes - 30/Mar/23 6:09 PM

Description

*Error:*
{noformat}
During inheritance return type should be compatible
{noformat}

*Affected Files:*
- /vendors/blesta/items/src/Collection/ItemCollection.php _(Line 65)_
- /vendors/blesta/pricing/src/Collection/ItemPriceCollection.php _(Line 298)_
- /vendors/blesta/h2o/h2o/nodes.php _(Line 55)_

*Possible solution:*
Add the "{{#[\ReturnTypeWillChange]}}" attribute to all the methods of the affected classes.

*Error:*
{noformat}
During inheritance return type should be compatible
{noformat}

*Affected Files:*
- /vendors/blesta/items/src/Collection/ItemCollection.php _(Line 65)_
- /vendors/blesta/pricing/src/Collection/ItemPriceCollection.php _(Line 298)_
- /vendors/blesta/h2o/h2o/nodes.php _(Line 55)_
- /vendors/blesta/h2o/h2o/context.php _(Line 47)_

*Possible solution:*
Add the "{{#[\ReturnTypeWillChange]}}" attribute to all the methods of the affected classes.

Abdy Franco made changes - 30/Mar/23 6:16 PM

Description

*Error:*
{noformat}
During inheritance return type should be compatible
{noformat}

*Affected Files:*
- /vendors/blesta/items/src/Collection/ItemCollection.php _(Line 65)_
- /vendors/blesta/pricing/src/Collection/ItemPriceCollection.php _(Line 298)_
- /vendors/blesta/h2o/h2o/nodes.php _(Line 55)_
- /vendors/blesta/h2o/h2o/context.php _(Line 47)_

*Possible solution:*
Add the "{{#[\ReturnTypeWillChange]}}" attribute to all the methods of the affected classes.

*Error:*
{noformat}
During inheritance return type should be compatible
{noformat}

*Affected Files:*
- /vendors/blesta/items/src/Collection/ItemCollection.php _(Line 65)_
- /vendors/blesta/pricing/src/Collection/ItemPriceCollection.php _(Line 298)_
- /vendors/blesta/h2o/h2o/nodes.php _(Line 55)_
- /vendors/blesta/h2o/h2o/context.php _(Line 47)_
- /plugins/phpids/lib/IDS/Report.php _(Line 214)_

*Possible solution:*
Add the "{{#[\ReturnTypeWillChange]}}" attribute to all the methods of the affected classes.

Abdy Franco made changes - 30/Mar/23 6:28 PM

Description

*Error:*
{noformat}
During inheritance return type should be compatible
{noformat}

*Affected Files:*
- /vendors/blesta/items/src/Collection/ItemCollection.php _(Line 65)_
- /vendors/blesta/pricing/src/Collection/ItemPriceCollection.php _(Line 298)_
- /vendors/blesta/h2o/h2o/nodes.php _(Line 55)_
- /vendors/blesta/h2o/h2o/context.php _(Line 47)_
- /plugins/phpids/lib/IDS/Report.php _(Line 214)_

*Possible solution:*
Add the "{{#[\ReturnTypeWillChange]}}" attribute to all the methods of the affected classes.

*Error:*
{noformat}
During inheritance return type should be compatible
{noformat}

*Affected Files:*
- /vendors/blesta/items/src/Collection/ItemCollection.php _(Line 65)_
- /vendors/blesta/pricing/src/Collection/ItemPriceCollection.php _(Line 298)_
- /vendors/blesta/h2o/h2o/nodes.php _(Line 55)_
- /vendors/blesta/h2o/h2o/context.php _(Line 47)_
- /plugins/phpids/lib/IDS/Report.php _(Line 214)_
- /plugins/phpids/lib/IDS/Event.php _(Line 211)_

*Possible solution:*
Add the "{{#[\ReturnTypeWillChange]}}" attribute to all the methods of the affected classes.

Abdy Franco made changes - 03/Apr/23 10:51 PM

Description

*Error:*
{noformat}
During inheritance return type should be compatible
{noformat}

*Affected Files:*
- /vendors/blesta/items/src/Collection/ItemCollection.php _(Line 65)_
- /vendors/blesta/pricing/src/Collection/ItemPriceCollection.php _(Line 298)_
- /vendors/blesta/h2o/h2o/nodes.php _(Line 55)_
- /vendors/blesta/h2o/h2o/context.php _(Line 47)_
- /plugins/phpids/lib/IDS/Report.php _(Line 214)_
- /plugins/phpids/lib/IDS/Event.php _(Line 211)_

*Possible solution:*
Add the "{{#[\ReturnTypeWillChange]}}" attribute to all the methods of the affected classes.

*Error:*
{noformat}
During inheritance return type should be compatible
{noformat}

*Affected Files:*
- /vendors/blesta/items/src/Collection/ItemCollection.php _(Line 65)_
- /vendors/blesta/pricing/src/Collection/ItemPriceCollection.php _(Line 298)_
- /vendors/blesta/h2o/h2o/nodes.php _(Line 55)_
- /vendors/blesta/h2o/h2o/context.php _(Line 47)_

*Possible solution:*
Add the "{{#[\ReturnTypeWillChange]}}" attribute to all the methods of the affected classes.

Abdy Franco made changes - 05/Apr/23 11:28 PM

Description

*Error:*
{noformat}
During inheritance return type should be compatible
{noformat}

*Affected Files:*
- /vendors/blesta/items/src/Collection/ItemCollection.php _(Line 65)_
- /vendors/blesta/pricing/src/Collection/ItemPriceCollection.php _(Line 298)_
- /vendors/blesta/h2o/h2o/nodes.php _(Line 55)_
- /vendors/blesta/h2o/h2o/context.php _(Line 47)_

*Possible solution:*
Add the "{{#[\ReturnTypeWillChange]}}" attribute to all the methods of the affected classes.

Paul Phillips made changes - 04/May/23 6:23 PM

Fix Version/s		5.7.0 [ 11800 ]
Fix Version/s	5.7.0-b1 [ 11737 ]

Paul Phillips made changes - 24/May/23 4:32 PM

Fix Version/s		5.8.0-b1 [ 11742 ]
Fix Version/s	5.7.0 [ 11800 ]

Jonathan Reissmueller made changes - 26/May/23 6:43 PM

Assignee

Jonathan Reissmueller [ jonathan ]

Jonathan Reissmueller made changes - 26/May/23 6:43 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Jonathan Reissmueller made changes - 26/May/23 8:00 PM

Status	In Progress [ 3 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]

People

Assignee:

Jonathan Reissmueller

Reporter:

Abdy Franco

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

28/Mar/23 6:28 PM

Updated:

26/May/23 8:00 PM

Resolved:

26/May/23 8:00 PM

Fix Release Date:

4/Aug/23

Agile

Completed Sprints:

5.7.0 Sprint 2 ended 13/Dec/22
5.7.0 Sprint 3 ended 28/Dec/22
5.8.0 Sprint 1 ended 02/Jun/23
5.8.0 Sprint 2 ended 19/Jun/23
5.8.0 Sprint 3 ended 12/Jul/23
5.8.0 Sprint 4 ended 26/Jul/23
View on Board