Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.10.0-b1
-
Component/s: Client Interface, Staff Interface
-
Labels:None
Description
Under Settings > Company > Look and Feel you can set a color theme, and change colors, etc. The theme is loaded in structure for both the admin and client areas. For example:
<link href="/admin/theme/theme.css?dir=" rel="stylesheet" type="text/css" media="screen" />
<link href="/client/theme/theme.css?dir=" rel="stylesheet" type="text/css" media="screen" />
Every page load Blesta does a query and fetches the theme data and builds the CSS file and sends it to the browser. However, this not an insignificant amount of overhead. Rather, the CSS files should be able to be cached by the browser. They may be sending a no-cache header. Ideally, we should set a version or hash in the URL after theme.css like theme.css?ver=12345678 and allow the browser to cache. Then, if the theme is changed in any way (select new theme or change colors and save a theme) the version would be updated and the browser would know to download and cache the new version.
Activity
Paul Phillips
created issue -
Paul Phillips
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 5.10.0-b1 [ 11905 ] |
Paul Phillips
made changes -
| Assignee | Jonathan Reissmueller [ jonathan ] |
Paul Phillips
made changes -
| Rank | Ranked higher |
Paul Phillips
made changes -
| Rank | Ranked lower |
| Rank | Ranked higher |
| Sprint | 5.10.0 Sprint 1 [ 188 ] |
| Assignee | Jonathan Reissmueller [ jonathan ] | Abdy Franco [ abdy ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 1 hour, 15 minutes [ 4500 ] | |
| Worklog Id | 16705 [ 16705 ] |
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Sprint | 5.10.0 Sprint 1 [ 188 ] | 5.10.0 Sprint 1, 5.10.0 Sprint 2 [ 188, 189 ] |
| Rank | Ranked higher |
| Sprint | 5.10.0 Sprint 1, 5.10.0 Sprint 2 [ 188, 189 ] | 5.10.0 Sprint 1, 5.10.0 Sprint 2, 5.10.0 Sprint 3 [ 188, 189, 190 ] |
| Rank | Ranked higher |
| Sprint | 5.10.0 Sprint 1, 5.10.0 Sprint 2, 5.10.0 Sprint 3 [ 188, 189, 190 ] | 5.10.0 Sprint 1, 5.10.0 Sprint 2, 5.10.0 Sprint 3, 5.10.0 Sprint 4 [ 188, 189, 190, 191 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Status | In Review [ 5 ] | Closed [ 6 ] |
