Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-5067

2FA: Spaces in company name cause issue with setting up new TOTP token

    Details

      Description

      The 2FA system allows clients and staff to scan a QR code to set up TOTP. Some tokens like LastPass and Oracle do not work when there is an unescaped space in the Company Name.

      Reported, not yet tested internally.

      Issue: Space Character in Issuer Section within OTP QR code doesn't work with all 3P authenticator apps

      To reproduce:
      Install LastPass or Oracle authenticator
      Generate MFA code in the account section
      Scan code with app
      App fails registration with unknown/generic error
      Note: it appears Google and Microsoft just fix the space on their own

      Root cause:
      Sample decoded qr code (current generated code in prod), notice the space before the "LLC" in the issuer section:
      otpauth://totp/email%40gmail.com?secret=secret&issuer=MyHost LLC

      To Fix:
      Use URL encoding for the space, %20:
      otpauth://totp/email%40gmail.com?secret=secret&issuer=MyHost%20LLC

        Activity

        admin Paul Phillips created issue -
        admin Paul Phillips made changes -
        Field Original Value New Value
        Rank Ranked higher
        admin Paul Phillips made changes -
        Rank Ranked lower
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.10.0 Sprint 5 [ 192 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        abdy Abdy Franco made changes -
        Assignee Abdy Franco [ abdy ]
        abdy Abdy Franco made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        abdy Abdy Franco made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 27 minutes [ 1620 ]
        Worklog Id 16846 [ 16846 ]
        abdy Abdy Franco made changes -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.10.0 Sprint 5 [ 192 ] 5.10.0 Sprint 5, 5.10.0 Sprint 6 [ 192, 193 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Fix Version/s 5.9.3 [ 11913 ]
        Fix Version/s 5.10.0-b1 [ 11905 ]
        jonathan Jonathan Reissmueller made changes -
        Status In Review [ 5 ] Closed [ 6 ]
        jonathan Jonathan Reissmueller made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked lower
        jonathan Jonathan Reissmueller made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            abdy Abdy Franco
            Reporter:
            admin Paul Phillips
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              21/Feb/24

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 27 minutes
              27m

                Agile