Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-5090

Escape quotes in text output to JS

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 5.10.0-b1
        • Component/s: None
        • Labels:
          None

          Description

          We ran into an issue recently with a French language string that was output into JS with an apostrophe thus breaking the JS syntax. We should be able to just escape those with addslashes() to avoid this kind of issue.

            Activity

            Ascending order - Click to sort in descending order
            jonathan Jonathan Reissmueller created issue -
            jonathan Jonathan Reissmueller made changes -
            Field Original Value New Value
            Rank Ranked higher
            jonathan Jonathan Reissmueller made changes -
            Sprint 5.10.0 Sprint 6 [ 193 ]
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked lower
            jonathan Jonathan Reissmueller made changes -
            Assignee Jonathan Reissmueller [ jonathan ]
            jonathan Jonathan Reissmueller made changes -
            Status Open [ 1 ] In Review [ 5 ]
            Resolution Fixed [ 1 ]
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked higher
            jonathan Jonathan Reissmueller made changes -
            Sprint 5.10.0 Sprint 6 [ 193 ] 5.10.0 Sprint 6, 5.10.0 Sprint 7 [ 193, 195 ]
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked higher
            jonathan Jonathan Reissmueller made changes -
            Sprint 5.10.0 Sprint 6, 5.10.0 Sprint 7 [ 193, 195 ] 5.10.0 Sprint 6, 5.10.0 Sprint 7, 5.10.0 Sprint 8 [ 193, 195, 197 ]
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked higher
            abdy Abdy Franco made changes -
            Remaining Estimate 0 minutes [ 0 ]
            Time Spent 4 minutes [ 240 ]
            Worklog Id 16869 [ 16869 ]
            jonathan Jonathan Reissmueller made changes -
            Status In Review [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                jonathan Jonathan Reissmueller
                Reporter:
                jonathan Jonathan Reissmueller
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Apr/24

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 minutes
                  4m

                    Agile