Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-5201

Twilio: Fatal error when number doesn't exist

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.10.1
    • Component/s: None
    • Labels:
      None

      Description

      To reproduce:

      • Install twilio and enable invoice delivery message
      • Create a client without a phone number
      • Queue an invoice for delivery to the client
      • Run the cron for delivering the invoice
      Attempting to deliver invoices scheduled for delivery.
      Error: Argument 1 passed to Twilio\Rest\Api\V2010\Account\MessageList::create() must be of the type string, null given, called in .../components/messengers/twilio/twilio.php on line 151 #0 .../components/messengers/twilio/twilio.php(151): Twilio\Rest\Api\V2010\Account\MessageList->create(NULL, Array)
      #1 .../app/models/messenger_manager.php(626): Twilio->send('5', 'Hi Matthew,\r\nAn...', 'sms')
      #2 .../components/invoice_delivery/invoice_delivery.php(188): MessengerManager->send('invoice_deliver...', Array, Array, 'sms', 'paul2@blesta.co...')
      #3 .../core/Automation/Tasks/Task/DeliverInvoices.php(270): InvoiceDelivery->deliverInvoices(Array, 'sms', 'paul2@blesta.co...', NULL, Array)
      #4 .../core/Automation/Tasks/Task/DeliverInvoices.php(85): Blesta\Core\Automation\Tasks\Task\DeliverInvoices->sendInvoices(Array, Object(stdClass), 'email', 'unpaid')
      #5 .../core/Automation/Tasks/Task/DeliverInvoices.php(55): Blesta\Core\Automation\Tasks\Task\DeliverInvoices->process()
      #6 .../app/controllers/cron.php(435): Blesta\Core\Automation\Tasks\Task\DeliverInvoices->run()
      #7 .../app/controllers/cron.php(203): Cron->deliverInvoices(1717434989.3127)
      #8 .../app/controllers/cron.php(151): Cron->all(1717434989.3127)
      #9 .../vendors/minphp/bridge/src/Lib/Dispatcher.php(142): Cron->index()
      #10 .../vendors/minphp/bridge/src/Lib/Dispatcher.php(61): Dispatcher::dispatch('/cron/', true)
      #11 .../index.php(24): Dispatcher::dispatchCli(Array)
      #12 {main}Attempting to provision paid pending services.
      

        Activity

        jonathan Jonathan Reissmueller created issue -
        jonathan Jonathan Reissmueller made changes -
        Field Original Value New Value
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.11.0 Sprint 1 [ 201 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Description
        {code:java}
        Attempting to deliver invoices scheduled for delivery.
        Error: Argument 1 passed to Twilio\Rest\Api\V2010\Account\MessageList::create() must be of the type string, null given, called in .../components/messengers/twilio/twilio.php on line 151 #0 .../components/messengers/twilio/twilio.php(151): Twilio\Rest\Api\V2010\Account\MessageList->create(NULL, Array)
        #1 .../app/models/messenger_manager.php(626): Twilio->send('5', 'Hi Matthew,\r\nAn...', 'sms')
        #2 .../components/invoice_delivery/invoice_delivery.php(188): MessengerManager->send('invoice_deliver...', Array, Array, 'sms', 'paul2@blesta.co...')
        #3 .../core/Automation/Tasks/Task/DeliverInvoices.php(270): InvoiceDelivery->deliverInvoices(Array, 'sms', 'paul2@blesta.co...', NULL, Array)
        #4 .../core/Automation/Tasks/Task/DeliverInvoices.php(85): Blesta\Core\Automation\Tasks\Task\DeliverInvoices->sendInvoices(Array, Object(stdClass), 'email', 'unpaid')
        #5 .../core/Automation/Tasks/Task/DeliverInvoices.php(55): Blesta\Core\Automation\Tasks\Task\DeliverInvoices->process()
        #6 .../app/controllers/cron.php(435): Blesta\Core\Automation\Tasks\Task\DeliverInvoices->run()
        #7 .../app/controllers/cron.php(203): Cron->deliverInvoices(1717434989.3127)
        #8 .../app/controllers/cron.php(151): Cron->all(1717434989.3127)
        #9 .../vendors/minphp/bridge/src/Lib/Dispatcher.php(142): Cron->index()
        #10 .../vendors/minphp/bridge/src/Lib/Dispatcher.php(61): Dispatcher::dispatch('/cron/', true)
        #11 .../index.php(24): Dispatcher::dispatchCli(Array)
        #12 {main}Attempting to provision paid pending services.
        {code}
        To reproduce:
        - Install twilio and enable invoice delivery message
        - Create a client without a phone number
        - Queue an invoice for delivery to the client
        - Run the cron for delivering the invoice

        {code:java}
        Attempting to deliver invoices scheduled for delivery.
        Error: Argument 1 passed to Twilio\Rest\Api\V2010\Account\MessageList::create() must be of the type string, null given, called in .../components/messengers/twilio/twilio.php on line 151 #0 .../components/messengers/twilio/twilio.php(151): Twilio\Rest\Api\V2010\Account\MessageList->create(NULL, Array)
        #1 .../app/models/messenger_manager.php(626): Twilio->send('5', 'Hi Matthew,\r\nAn...', 'sms')
        #2 .../components/invoice_delivery/invoice_delivery.php(188): MessengerManager->send('invoice_deliver...', Array, Array, 'sms', 'paul2@blesta.co...')
        #3 .../core/Automation/Tasks/Task/DeliverInvoices.php(270): InvoiceDelivery->deliverInvoices(Array, 'sms', 'paul2@blesta.co...', NULL, Array)
        #4 .../core/Automation/Tasks/Task/DeliverInvoices.php(85): Blesta\Core\Automation\Tasks\Task\DeliverInvoices->sendInvoices(Array, Object(stdClass), 'email', 'unpaid')
        #5 .../core/Automation/Tasks/Task/DeliverInvoices.php(55): Blesta\Core\Automation\Tasks\Task\DeliverInvoices->process()
        #6 .../app/controllers/cron.php(435): Blesta\Core\Automation\Tasks\Task\DeliverInvoices->run()
        #7 .../app/controllers/cron.php(203): Cron->deliverInvoices(1717434989.3127)
        #8 .../app/controllers/cron.php(151): Cron->all(1717434989.3127)
        #9 .../vendors/minphp/bridge/src/Lib/Dispatcher.php(142): Cron->index()
        #10 .../vendors/minphp/bridge/src/Lib/Dispatcher.php(61): Dispatcher::dispatch('/cron/', true)
        #11 .../index.php(24): Dispatcher::dispatchCli(Array)
        #12 {main}Attempting to provision paid pending services.
        {code}
        jonathan Jonathan Reissmueller made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        jonathan Jonathan Reissmueller made changes -
        Status Open [ 1 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        abdy Abdy Franco made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 8 minutes [ 480 ]
        Worklog Id 17134 [ 17134 ]
        jonathan Jonathan Reissmueller made changes -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            jonathan Jonathan Reissmueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              26/Jun/24

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 8 minutes
              8m

                Agile