Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-5272

Cannot change a contact type and the type is displayed incorrectly in the client area.

    Details

      Description

      Two things, I suspect they may be related.

      1. It's not possible to change a contact type back to "Billing" if it is created using another type.
      2. The client area under /client/contacts/ lists all contacts of the type "Billing", when they are of another status.

      To reproduce:

      1. Create a new contact under /admin/settings/company/general/contacttypes/ and call it "Support" for consistency.
      2. Create a contact under a client profile and set the type to "Support".
      3. Edit the contact and change it to "Billing". Note that it remains "Support".

      Second issue:

      1. In the client area, visit /client/contacts/ and note that all contacts are shown with the type "Billing", even if they are using the custom contact "Support".

      In both of these cases, a successful message is shown and no error logs are logged. The info log is updated to show the contact_type change but is always represented as "billing" with an ID of "1".

      [2024-11-11T20:02:08.906395+00:00] general.INFO: Updated Contact Permissions {"contact_id":"3","by_user_id":1}
      [2024-11-11T20:02:08.908774+00:00] general.INFO: Updated Contact {"contact_id":"3","by_user_id":1,"first_name":"Elisa","last_name":"Martinez","company":"","title":"","address1":"1234 E. Lane","address2":"","city":"Jacksonville","country":"US","state":"AL","zip":"12121","email":"email@domain.com","contact_type":"billing","contact_type_id":"1"}
      

        Activity

        admin Paul Phillips created issue -
        admin Paul Phillips made changes -
        Field Original Value New Value
        Rank Ranked higher
        admin Paul Phillips made changes -
        Sprint 5.11.0 Sprint 5 [ 204 ]
        admin Paul Phillips made changes -
        Rank Ranked lower
        admin Paul Phillips made changes -
        Description Two things, I suspect they may be related.

        1. It's not possible to change a contact type back to "Billing" if it is created using another type.
        2. The client area under /client/contacts/ lists all contacts of the type "Billing", when they are of another status.

        To reproduce:

        1. Create a new contact under /admin/settings/company/general/contacttypes/ and call it "Support" for consistency.
        2. Create a contact under a client profile and set the type to "Support".
        3. Edit the contact and change it to "Billing". Note that it remains "Support".

        Second issue:

        1. In the client area, visit /client/contacts/ and note that all contacts are shown with the type "Billing", even if they are using the custom contact "Support".

        In both of these cases, a successful message is shown and no error logs are logged. The info log is updated to show the contact_type change but is always represented as "billing" with an ID of "1".

        {code:java}
        [2024-11-11T20:02:08.906395+00:00] general.INFO: Updated Contact Permissions {"contact_id":"3","by_user_id":1}
        [2024-11-11T20:02:08.908774+00:00] general.INFO: Updated Contact {"contact_id":"3","by_user_id":1,"first_name":"Elisa","last_name":"Martinez","company":"","title":"","address1":"1234 E. Lane","address2":"","city":"Jacksonville","country":"US","state":"AL","zip":"12121","email":"paul4@blesta.com","contact_type":"billing","contact_type_id":"1"}
        {code}


        Two things, I suspect they may be related.

        1. It's not possible to change a contact type back to "Billing" if it is created using another type.
        2. The client area under /client/contacts/ lists all contacts of the type "Billing", when they are of another status.

        To reproduce:

        1. Create a new contact under /admin/settings/company/general/contacttypes/ and call it "Support" for consistency.
        2. Create a contact under a client profile and set the type to "Support".
        3. Edit the contact and change it to "Billing". Note that it remains "Support".

        Second issue:

        1. In the client area, visit /client/contacts/ and note that all contacts are shown with the type "Billing", even if they are using the custom contact "Support".

        In both of these cases, a successful message is shown and no error logs are logged. The info log is updated to show the contact_type change but is always represented as "billing" with an ID of "1".

        {code:java}
        [2024-11-11T20:02:08.906395+00:00] general.INFO: Updated Contact Permissions {"contact_id":"3","by_user_id":1}
        [2024-11-11T20:02:08.908774+00:00] general.INFO: Updated Contact {"contact_id":"3","by_user_id":1,"first_name":"Elisa","last_name":"Martinez","company":"","title":"","address1":"1234 E. Lane","address2":"","city":"Jacksonville","country":"US","state":"AL","zip":"12121","email":"email@domain.com","contact_type":"billing","contact_type_id":"1"}
        {code}


        jonathan Jonathan Reissmueller made changes -
        Sprint 5.11.0 Sprint 5 [ 204 ] 5.11.0 Sprint 5, 5.11.0 Sprint 6 [ 204, 206 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked lower
        abdy Abdy Franco made changes -
        Assignee Abdy Franco [ abdy ]
        abdy Abdy Franco made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        abdy Abdy Franco made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 45 minutes [ 2700 ]
        Worklog Id 17469 [ 17469 ]
        abdy Abdy Franco made changes -
        Time Spent 45 minutes [ 2700 ] 2 hours, 52 minutes [ 10320 ]
        Worklog Id 17470 [ 17470 ]
        abdy Abdy Franco made changes -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            abdy Abdy Franco
            Reporter:
            admin Paul Phillips
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 2 hours, 52 minutes
              2h 52m

                Agile