[CORE-5539] Domains: Daily expiration sync targets all domains instead of a subset - Blesta

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 5.13.0-b1
Component/s: None
Labels:
None

Description

domains_plugin.php around line 1431 change

            $client_groups = $this->ClientGroups->getAll(Configure::get('Blesta.company_id'));
            foreach ($client_groups as $client_group) {
                $inv_days_before_renewal = $this->ClientGroups->getSetting($client_group->id, 'inv_days_before_renewal');
                $pre_renewal_invoice_date = $this->Date->modify(
                        date('c'),
                        '-' . (($renewal_days->value ?? 0) + ($inv_days_before_renewal->value ?? 0) + 1) . ' days',
                        'Y-m-d 00:00:00',
                        Configure::get('Blesta.company_timezone')
                    );
                $filters = [
                    'services' => [
                        ['column' => 'date_renews', 'operator' => '>=', 'value' => $pre_renewal_invoice_date]
                    ],
                    'clients' => [
                        ['column' => 'client_group_id', 'operator' => '=', 'value' => $client_group->id]
                    ],
                ];
                $services = $this->DomainsDomains->getAll([], ['date_added' => 'DESC'], $filters);
                $this->synchronizeDomainServices($services, $renewal_days);
            }

            $client_groups = $this->ClientGroups->getAll(Configure::get('Blesta.company_id'));
            foreach ($client_groups as $client_group) {
                $inv_days_before_renewal = $this->ClientGroups->getSetting($client_group->id, 'inv_days_before_renewal');
                $pre_renewal_invoice_date = $this->Date->modify(
                        date('c'),
                        '+' . (($inv_days_before_renewal->value ?? 0) + 5) . ' days',
                        'Y-m-d 00:00:00',
                        Configure::get('Blesta.company_timezone')
                    );
                $filters = [
                    'services' => [
                        ['column' => 'date_renews', 'operator' => '<=', 'value' => $pre_renewal_invoice_date]
                    ],
                    'clients' => [
                        ['column' => 'client_group_id', 'operator' => '=', 'value' => $client_group->id]
                    ],
                ];
                $services = $this->DomainsDomains->getAll([], ['date_added' => 'DESC'], $filters);
                $this->synchronizeDomainServices($services, $renewal_days);
            }

Activity

Ascending order - Click to sort in descending order

Jonathan Reissmueller created issue - 31/Oct/25 3:37 PM

Jonathan Reissmueller made changes - 31/Oct/25 3:43 PM

Field	Original Value	New Value
Sprint		5.13.0 Sprint 6 [ 221 ]

Jonathan Reissmueller made changes - 31/Oct/25 3:43 PM

Rank

Ranked higher

Jonathan Reissmueller made changes - 31/Oct/25 3:44 PM

Description

domains_plugin.php around line 1431 change

{code:java}
            $client_groups = $this->ClientGroups->getAll(Configure::get('Blesta.company_id'));
            foreach ($client_groups as $client_group) {
                $inv_days_before_renewal = $this->ClientGroups->getSetting($client_group->id, 'inv_days_before_renewal');
                $pre_renewal_invoice_date = $this->Date->modify(
                        date('c'),
                        '-' . (($renewal_days->value ?? 0) + ($inv_days_before_renewal->value ?? 0) + 1) . ' days',
                        'Y-m-d 00:00:00',
                        Configure::get('Blesta.company_timezone')
                    );
                $filters = [
                    'services' => [
                        ['column' => 'date_renews', 'operator' => '>=', 'value' => $pre_renewal_invoice_date]
                    ],
                    'clients' => [
                        ['column' => 'client_group_id', 'operator' => '=', 'value' => $client_group->id]
                    ],
                ];
                $services = $this->DomainsDomains->getAll([], ['date_added' => 'DESC'], $filters);
                $this->synchronizeDomainServices($services, $renewal_days);
            }
{code}

To

{code:java}
            $client_groups = $this->ClientGroups->getAll(Configure::get('Blesta.company_id'));
            foreach ($client_groups as $client_group) {
                $inv_days_before_renewal = $this->ClientGroups->getSetting($client_group->id, 'inv_days_before_renewal');
                $pre_renewal_invoice_date = $this->Date->modify(
                        date('c'),
                        '+' . (($inv_days_before_renewal->value ?? 0) + 1) . ' days',
                        'Y-m-d 00:00:00',
                        Configure::get('Blesta.company_timezone')
                    );
                $filters = [
                    'services' => [
                        ['column' => 'date_renews', 'operator' => '<=', 'value' => $pre_renewal_invoice_date]
                    ],
                    'clients' => [
                        ['column' => 'client_group_id', 'operator' => '=', 'value' => $client_group->id]
                    ],
                ];
                $services = $this->DomainsDomains->getAll([], ['date_added' => 'DESC'], $filters);
                $this->synchronizeDomainServices($services, $renewal_days);
            }
{code}

domains_plugin.php around line 1431 change

{code:java}
            $client_groups = $this->ClientGroups->getAll(Configure::get('Blesta.company_id'));
            foreach ($client_groups as $client_group) {
                $inv_days_before_renewal = $this->ClientGroups->getSetting($client_group->id, 'inv_days_before_renewal');
                $pre_renewal_invoice_date = $this->Date->modify(
                        date('c'),
                        '-' . (($renewal_days->value ?? 0) + ($inv_days_before_renewal->value ?? 0) + 1) . ' days',
                        'Y-m-d 00:00:00',
                        Configure::get('Blesta.company_timezone')
                    );
                $filters = [
                    'services' => [
                        ['column' => 'date_renews', 'operator' => '>=', 'value' => $pre_renewal_invoice_date]
                    ],
                    'clients' => [
                        ['column' => 'client_group_id', 'operator' => '=', 'value' => $client_group->id]
                    ],
                ];
                $services = $this->DomainsDomains->getAll([], ['date_added' => 'DESC'], $filters);
                $this->synchronizeDomainServices($services, $renewal_days);
            }
{code}

To

{code:java}
            $client_groups = $this->ClientGroups->getAll(Configure::get('Blesta.company_id'));
            foreach ($client_groups as $client_group) {
                $inv_days_before_renewal = $this->ClientGroups->getSetting($client_group->id, 'inv_days_before_renewal');
                $pre_renewal_invoice_date = $this->Date->modify(
                        date('c'),
                        '+' . (($inv_days_before_renewal->value ?? 0) + 5) . ' days',
                        'Y-m-d 00:00:00',
                        Configure::get('Blesta.company_timezone')
                    );
                $filters = [
                    'services' => [
                        ['column' => 'date_renews', 'operator' => '<=', 'value' => $pre_renewal_invoice_date]
                    ],
                    'clients' => [
                        ['column' => 'client_group_id', 'operator' => '=', 'value' => $client_group->id]
                    ],
                ];
                $services = $this->DomainsDomains->getAll([], ['date_added' => 'DESC'], $filters);
                $this->synchronizeDomainServices($services, $renewal_days);
            }
{code}

Abdy Franco made changes - 05/Nov/25 10:31 PM

Assignee

Abdy Franco [ abdy ]

Abdy Franco made changes - 05/Nov/25 10:31 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Abdy Franco made changes - 05/Nov/25 10:31 PM

Remaining Estimate		0 minutes [ 0 ]
Time Spent		33 minutes [ 1980 ]
Worklog Id	17969 [ 17969 ]

Abdy Franco made changes - 05/Nov/25 10:31 PM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Jonathan Reissmueller made changes - 06/Nov/25 4:12 PM

Status

In Review [ 5 ]

Closed [ 6 ]

People

Assignee:

Abdy Franco

Reporter:

Jonathan Reissmueller

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

31/Oct/25 3:37 PM

Updated:

06/Nov/25 4:12 PM

Resolved:

05/Nov/25 10:31 PM

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

33m

Agile

Completed Sprint:

5.13.0 Sprint 6 ended 14/Nov/25
View on Board