[CORE-652] Order: Need to display service prices with any tax inclusive amounts - Blesta

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.0.0.b7
Fix Version/s: 4.1.1, 4.2.0-b1
Component/s: Plugins
Labels:
None

Description

When adding services (through order form or when adding an addon service through the client interface) we need to display service prices to include any tax inclusive amounts.

Issue Links

relates to

CORE-2464 Exclude 'exclusive' taxes from appearing in totals

Closed

Activity

Ascending order - Click to sort in descending order

Cody Phillips (Inactive) created issue - 10/Aug/13 2:33 PM

Paul Phillips made changes - 14/Aug/13 11:59 AM

Field	Original Value	New Value
Fix Version/s		3.0.1 [ 10212 ]
Fix Version/s	3.0.0 [ 10000 ]

Paul Phillips made changes - 21/Aug/13 6:46 PM

Fix Version/s		3.0.2 [ 10213 ]
Fix Version/s	3.0.1 [ 10212 ]

Paul Phillips made changes - 03/Sep/13 4:15 PM

Fix Version/s		3.0.3 [ 10214 ]
Fix Version/s	3.0.2 [ 10213 ]

Paul Phillips made changes - 18/Sep/13 3:31 PM

Fix Version/s		3.0.4 [ 10215 ]
Fix Version/s	3.0.3 [ 10214 ]

Paul Phillips made changes - 07/Oct/13 6:33 PM

Fix Version/s		3.0.5 [ 10300 ]
Fix Version/s	3.0.4 [ 10215 ]

Paul Phillips made changes - 24/Oct/13 4:17 PM

Fix Version/s		3.0.6 [ 10301 ]
Fix Version/s	3.0.5 [ 10300 ]

Paul Phillips made changes - 13/Nov/13 6:27 PM

Fix Version/s		3.0.7 [ 10302 ]
Fix Version/s	3.0.6 [ 10301 ]

Paul Phillips made changes - 20/Dec/13 3:45 PM

Fix Version/s		3.0.8 [ 10304 ]
Fix Version/s	3.0.7 [ 10302 ]

Paul Phillips made changes - 16/Jan/14 2:19 PM

Fix Version/s		3.1.1 [ 10306 ]
Fix Version/s	3.0.8 [ 10304 ]

Paul Phillips made changes - 12/Feb/14 3:50 PM

Fix Version/s		3.1.2 [ 10403 ]
Fix Version/s	3.1.1 [ 10306 ]

Paul Phillips made changes - 26/Feb/14 5:04 PM

Fix Version/s		3.1.3 [ 10405 ]
Fix Version/s	3.1.2 [ 10403 ]

Paul Phillips made changes - 27/Mar/14 11:31 AM

Fix Version/s		3.1.4 [ 10500 ]
Fix Version/s	3.1.3 [ 10405 ]

Paul Phillips made changes - 14/May/14 1:09 PM

Fix Version/s		3.2.1 [ 10504 ]
Fix Version/s	3.1.4 [ 10500 ]

Paul Phillips made changes - 25/Jun/14 7:07 PM

Fix Version/s		3.2.2 [ 10505 ]
Fix Version/s	3.2.1 [ 10504 ]

Paul Phillips made changes - 30/Jul/14 5:25 PM

Fix Version/s		3.2.3 [ 10506 ]
Fix Version/s	3.2.2 [ 10505 ]

Paul Phillips made changes - 06/Oct/14 5:37 PM

Fix Version/s		3.3.0 [ 10508 ]
Fix Version/s	3.2.3 [ 10506 ]

Tyson Phillips (Inactive) made changes - 21/Oct/14 7:07 PM

Fix Version/s		3.3.2 [ 10602 ]
Fix Version/s	3.3.0 [ 10508 ]

Paul Phillips made changes - 11/Nov/14 2:09 PM

Fix Version/s		3.3.3 [ 10604 ]
Fix Version/s	3.3.2 [ 10602 ]

Cody Phillips (Inactive) made changes - 26/Jan/15 6:42 PM

Fix Version/s

3.3.3 [ 10604 ]

Cody Phillips (Inactive) made changes - 23/Mar/15 11:17 AM

Rank

Ranked higher

Cody Phillips (Inactive) made changes - 13/May/15 11:37 AM

Rank

Ranked higher

Tyson Phillips (Inactive) made changes - 21/Feb/17 3:45 PM

Assignee

Cody Phillips [ cody ]

Hide

Permalink

Tyson Phillips (Inactive) added a comment - 21/Feb/17 3:47 PM

I think the new pricing presenters should already handle this behavior if they are being used in those locations, otherwise they will probably need to be used for it.

Show

Tyson Phillips (Inactive) added a comment - 21/Feb/17 3:47 PM I think the new pricing presenters should already handle this behavior if they are being used in those locations, otherwise they will probably need to be used for it.

Tyson Phillips (Inactive) made changes - 30/Aug/17 6:35 PM

Fix Version/s		4.1.1 [ 11015 ]
Fix Version/s		4.2.0-b1 [ 11014 ]

Tyson Phillips (Inactive) made changes - 30/Aug/17 6:35 PM

Assignee

Jonathan Reissmueller [ jonathan ]

Hide

Permalink

Tyson Phillips (Inactive) added a comment - 30/Aug/17 6:36 PM

Need to check whether this issue is already resolved by this functionality using the pricing presenters.

Show

Tyson Phillips (Inactive) added a comment - 30/Aug/17 6:36 PM Need to check whether this issue is already resolved by this functionality using the pricing presenters.

Tyson Phillips (Inactive) made changes - 30/Aug/17 7:36 PM

Sprint

4.2.0 Sprint 1 [ 44 ]

Tyson Phillips (Inactive) made changes - 30/Aug/17 7:36 PM

Rank

Ranked higher

Jonathan Reissmueller made changes - 01/Sep/17 7:04 PM

Remaining Estimate		0 minutes [ 0 ]
Time Spent		40 minutes [ 2400 ]
Worklog Id	10222 [ 10222 ]

Hide

Permalink

Jonathan Reissmueller added a comment - 05/Sep/17 2:37 PM

So it seems that the service presenter treats all taxes as inclusive. It always includes the tax amounts in the overall total. This can be seen in the tax functions of the ItemPrice class, there is no reference to type in those methods or the TaxPrice method that it calls.

Show

Jonathan Reissmueller added a comment - 05/Sep/17 2:37 PM So it seems that the service presenter treats all taxes as inclusive. It always includes the tax amounts in the overall total. This can be seen in the tax functions of the ItemPrice class, there is no reference to type in those methods or the TaxPrice method that it calls.

Jonathan Reissmueller made changes - 05/Sep/17 2:38 PM

Time Spent	40 minutes [ 2400 ]	1 hour, 51 minutes [ 6660 ]
Worklog Id	10225 [ 10225 ]

Hide

Permalink

Tyson Phillips (Inactive) added a comment - 05/Sep/17 6:23 PM

You may have to show this to me. I believe the item price collection should already handle this, or make it possible to fetch the totals with and without tax included, in which case the tax inclusivity/exclusivity would be determined later, wherever it is necessary to be displayed.

Show

Tyson Phillips (Inactive) added a comment - 05/Sep/17 6:23 PM You may have to show this to me. I believe the item price collection should already handle this, or make it possible to fetch the totals with and without tax included, in which case the tax inclusivity/exclusivity would be determined later, wherever it is necessary to be displayed.

Jonathan Reissmueller made changes - 07/Sep/17 5:08 PM

Time Spent	1 hour, 51 minutes [ 6660 ]	2 hours, 6 minutes [ 7560 ]
Worklog Id	10235 [ 10235 ]

Automated transition triggered when Jonathan Reissmueller created a branch in Stash - 08/Sep/17 2:50 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Jonathan Reissmueller made changes - 08/Sep/17 4:31 PM

Time Spent	2 hours, 6 minutes [ 7560 ]	3 hours, 16 minutes [ 11760 ]
Worklog Id	10241 [ 10241 ]

Jonathan Reissmueller made changes - 11/Sep/17 2:31 PM

Time Spent	3 hours, 16 minutes [ 11760 ]	6 hours, 25 minutes [ 23100 ]
Worklog Id	10242 [ 10242 ]

Jonathan Reissmueller made changes - 12/Sep/17 12:57 PM

Time Spent	6 hours, 25 minutes [ 23100 ]	7 hours, 46 minutes [ 27960 ]
Worklog Id	10245 [ 10245 ]

Automated transition triggered when Jonathan Reissmueller created pull request #28 in Stash - 13/Sep/17 2:39 PM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Jonathan Reissmueller made changes - 13/Sep/17 2:39 PM

Time Spent	7 hours, 46 minutes [ 27960 ]	1 day, 37 minutes [ 31020 ]
Worklog Id	10252 [ 10252 ]

Jonathan Reissmueller made changes - 15/Sep/17 2:35 PM

Remaining Estimate	0 minutes [ 0 ]	1 hour, 21 minutes [ 4860 ]
Time Spent	1 day, 37 minutes [ 31020 ]	7 hours, 16 minutes [ 26160 ]
Worklog Id	10245 [ 10245 ]
Worklog Time Spent	1 hour, 21 minutes [ 4860 ]

Jonathan Reissmueller made changes - 15/Sep/17 2:35 PM

Remaining Estimate	1 hour, 21 minutes [ 4860 ]	4 hours, 30 minutes [ 16200 ]
Time Spent	7 hours, 16 minutes [ 26160 ]	4 hours, 7 minutes [ 14820 ]
Worklog Id	10242 [ 10242 ]
Worklog Time Spent	3 hours, 9 minutes [ 11340 ]

Jonathan Reissmueller made changes - 15/Sep/17 2:36 PM

Remaining Estimate	4 hours, 30 minutes [ 16200 ]	5 hours, 40 minutes [ 20400 ]
Time Spent	4 hours, 7 minutes [ 14820 ]	2 hours, 57 minutes [ 10620 ]
Worklog Id	10241 [ 10241 ]
Worklog Time Spent	1 hour, 10 minutes [ 4200 ]

Automated transition triggered when Tyson Phillips (Inactive) merged pull request #28 in Stash - 19/Sep/17 6:45 PM

Status

In Review [ 5 ]

Closed [ 6 ]

Tyson Phillips (Inactive) made changes - 19/Sep/17 6:51 PM

Link

This issue relates to ~~CORE-2464~~ [ ~~CORE-2464~~ ]

Paul Phillips made changes - 26/Sep/17 4:32 PM

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Reopened [ 4 ]

Paul Phillips made changes - 26/Sep/17 4:33 PM

Security

Private [ 10000 ]

Paul Phillips made changes - 26/Sep/17 4:33 PM

Status	Reopened [ 4 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]

People

Assignee:

Jonathan Reissmueller

Reporter:

Cody Phillips (Inactive)

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

10/Aug/13 2:33 PM

Updated:

26/Sep/17 4:33 PM

Resolved:

26/Sep/17 4:33 PM

Fix Release Date:

27/Sep/17

Time Tracking

Estimated:

Not Specified

Remaining:

5h 40m

Logged:

2h 57m

Agile

Completed Sprint:

4.1.1 Sprint 1 ended 26/Sep/17
View on Board