Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-652

Order: Need to display service prices with any tax inclusive amounts

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0.b7
    • Fix Version/s: 4.1.1, 4.2.0-b1
    • Component/s: Plugins
    • Labels:
      None

      Description

      When adding services (through order form or when adding an addon service through the client interface) we need to display service prices to include any tax inclusive amounts.

        Issue Links

          Activity

          admin Paul Phillips made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          admin Paul Phillips made changes -
          Security Private [ 10000 ]
          admin Paul Phillips made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          tyson Tyson Phillips (Inactive) made changes -
          Link This issue relates to CORE-2464 [ CORE-2464 ]
          Automated transition triggered when Tyson Phillips (Inactive) merged pull request #28 in Stash -
          Status In Review [ 5 ] Closed [ 6 ]
          jonathan Jonathan Reissmueller made changes -
          Remaining Estimate 4 hours, 30 minutes [ 16200 ] 5 hours, 40 minutes [ 20400 ]
          Time Spent 4 hours, 7 minutes [ 14820 ] 2 hours, 57 minutes [ 10620 ]
          Worklog Id 10241 [ 10241 ]
          Worklog Time Spent 1 hour, 10 minutes [ 4200 ]
          jonathan Jonathan Reissmueller made changes -
          Remaining Estimate 1 hour, 21 minutes [ 4860 ] 4 hours, 30 minutes [ 16200 ]
          Time Spent 7 hours, 16 minutes [ 26160 ] 4 hours, 7 minutes [ 14820 ]
          Worklog Id 10242 [ 10242 ]
          Worklog Time Spent 3 hours, 9 minutes [ 11340 ]
          jonathan Jonathan Reissmueller made changes -
          Remaining Estimate 0 minutes [ 0 ] 1 hour, 21 minutes [ 4860 ]
          Time Spent 1 day, 37 minutes [ 31020 ] 7 hours, 16 minutes [ 26160 ]
          Worklog Id 10245 [ 10245 ]
          Worklog Time Spent 1 hour, 21 minutes [ 4860 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 7 hours, 46 minutes [ 27960 ] 1 day, 37 minutes [ 31020 ]
          Worklog Id 10252 [ 10252 ]
          Automated transition triggered when Jonathan Reissmueller created pull request #28 in Stash -
          Status In Progress [ 3 ] In Review [ 5 ]
          Resolution Fixed [ 1 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 6 hours, 25 minutes [ 23100 ] 7 hours, 46 minutes [ 27960 ]
          Worklog Id 10245 [ 10245 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 3 hours, 16 minutes [ 11760 ] 6 hours, 25 minutes [ 23100 ]
          Worklog Id 10242 [ 10242 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 2 hours, 6 minutes [ 7560 ] 3 hours, 16 minutes [ 11760 ]
          Worklog Id 10241 [ 10241 ]
          Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
          Status Open [ 1 ] In Progress [ 3 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 1 hour, 51 minutes [ 6660 ] 2 hours, 6 minutes [ 7560 ]
          Worklog Id 10235 [ 10235 ]
          Hide
          tyson Tyson Phillips (Inactive) added a comment -

          You may have to show this to me. I believe the item price collection should already handle this, or make it possible to fetch the totals with and without tax included, in which case the tax inclusivity/exclusivity would be determined later, wherever it is necessary to be displayed.

          Show
          tyson Tyson Phillips (Inactive) added a comment - You may have to show this to me. I believe the item price collection should already handle this, or make it possible to fetch the totals with and without tax included, in which case the tax inclusivity/exclusivity would be determined later, wherever it is necessary to be displayed.
          jonathan Jonathan Reissmueller made changes -
          Time Spent 40 minutes [ 2400 ] 1 hour, 51 minutes [ 6660 ]
          Worklog Id 10225 [ 10225 ]
          Hide
          jonathan Jonathan Reissmueller added a comment -

          So it seems that the service presenter treats all taxes as inclusive. It always includes the tax amounts in the overall total. This can be seen in the tax functions of the ItemPrice class, there is no reference to type in those methods or the TaxPrice method that it calls.

          Show
          jonathan Jonathan Reissmueller added a comment - So it seems that the service presenter treats all taxes as inclusive. It always includes the tax amounts in the overall total. This can be seen in the tax functions of the ItemPrice class, there is no reference to type in those methods or the TaxPrice method that it calls.
          jonathan Jonathan Reissmueller made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 40 minutes [ 2400 ]
          Worklog Id 10222 [ 10222 ]
          tyson Tyson Phillips (Inactive) made changes -
          Rank Ranked higher
          tyson Tyson Phillips (Inactive) made changes -
          Sprint 4.2.0 Sprint 1 [ 44 ]
          Hide
          tyson Tyson Phillips (Inactive) added a comment -

          Need to check whether this issue is already resolved by this functionality using the pricing presenters.

          Show
          tyson Tyson Phillips (Inactive) added a comment - Need to check whether this issue is already resolved by this functionality using the pricing presenters.
          tyson Tyson Phillips (Inactive) made changes -
          Assignee Jonathan Reissmueller [ jonathan ]
          tyson Tyson Phillips (Inactive) made changes -
          Fix Version/s 4.1.1 [ 11015 ]
          Fix Version/s 4.2.0-b1 [ 11014 ]
          Hide
          tyson Tyson Phillips (Inactive) added a comment -

          I think the new pricing presenters should already handle this behavior if they are being used in those locations, otherwise they will probably need to be used for it.

          Show
          tyson Tyson Phillips (Inactive) added a comment - I think the new pricing presenters should already handle this behavior if they are being used in those locations, otherwise they will probably need to be used for it.
          tyson Tyson Phillips (Inactive) made changes -
          Assignee Cody Phillips [ cody ]
          cody Cody Phillips (Inactive) made changes -
          Rank Ranked higher
          cody Cody Phillips (Inactive) made changes -
          Rank Ranked higher
          cody Cody Phillips (Inactive) made changes -
          Fix Version/s 3.3.3 [ 10604 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.3.3 [ 10604 ]
          Fix Version/s 3.3.2 [ 10602 ]
          tyson Tyson Phillips (Inactive) made changes -
          Fix Version/s 3.3.2 [ 10602 ]
          Fix Version/s 3.3.0 [ 10508 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.3.0 [ 10508 ]
          Fix Version/s 3.2.3 [ 10506 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.2.3 [ 10506 ]
          Fix Version/s 3.2.2 [ 10505 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.2.2 [ 10505 ]
          Fix Version/s 3.2.1 [ 10504 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.2.1 [ 10504 ]
          Fix Version/s 3.1.4 [ 10500 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.1.4 [ 10500 ]
          Fix Version/s 3.1.3 [ 10405 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.1.3 [ 10405 ]
          Fix Version/s 3.1.2 [ 10403 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.1.2 [ 10403 ]
          Fix Version/s 3.1.1 [ 10306 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.1.1 [ 10306 ]
          Fix Version/s 3.0.8 [ 10304 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.0.8 [ 10304 ]
          Fix Version/s 3.0.7 [ 10302 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.0.7 [ 10302 ]
          Fix Version/s 3.0.6 [ 10301 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.0.6 [ 10301 ]
          Fix Version/s 3.0.5 [ 10300 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.0.5 [ 10300 ]
          Fix Version/s 3.0.4 [ 10215 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.0.4 [ 10215 ]
          Fix Version/s 3.0.3 [ 10214 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.0.3 [ 10214 ]
          Fix Version/s 3.0.2 [ 10213 ]
          admin Paul Phillips made changes -
          Fix Version/s 3.0.2 [ 10213 ]
          Fix Version/s 3.0.1 [ 10212 ]
          admin Paul Phillips made changes -
          Field Original Value New Value
          Fix Version/s 3.0.1 [ 10212 ]
          Fix Version/s 3.0.0 [ 10000 ]
          cody Cody Phillips (Inactive) created issue -

            People

            • Assignee:
              jonathan Jonathan Reissmueller
              Reporter:
              cody Cody Phillips (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                27/Sep/17

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Time Spent - 2 hours, 57 minutes Remaining Estimate - 5 hours, 40 minutes
                5h 40m
                Logged:
                Time Spent - 2 hours, 57 minutes Remaining Estimate - 5 hours, 40 minutes
                2h 57m

                  Agile