[CORE-861] Add option to calculate coupon discount with tax - Blesta

Cody Phillips (Inactive) created issue - 05/Nov/13 2:00 PM

Cody Phillips (Inactive) made changes - 05/Nov/13 2:00 PM

Field	Original Value	New Value
Priority	Major [ 3 ]	Critical [ 2 ]

Paul Phillips made changes - 13/Nov/13 6:27 PM

Fix Version/s		3.0.7 [ 10302 ]
Fix Version/s	3.0.6 [ 10301 ]

Paul Phillips made changes - 20/Dec/13 3:45 PM

Fix Version/s		3.0.8 [ 10304 ]
Fix Version/s	3.0.7 [ 10302 ]

Paul Phillips made changes - 16/Jan/14 2:19 PM

Fix Version/s		3.1.1 [ 10306 ]
Fix Version/s	3.0.8 [ 10304 ]

Paul Phillips made changes - 12/Feb/14 3:50 PM

Fix Version/s		3.1.2 [ 10403 ]
Fix Version/s	3.1.1 [ 10306 ]

Paul Phillips made changes - 26/Feb/14 5:04 PM

Fix Version/s		3.1.3 [ 10405 ]
Fix Version/s	3.1.2 [ 10403 ]

Paul Phillips made changes - 27/Mar/14 11:31 AM

Fix Version/s		3.1.4 [ 10500 ]
Fix Version/s	3.1.3 [ 10405 ]

Paul Phillips made changes - 14/May/14 1:09 PM

Fix Version/s		3.2.1 [ 10504 ]
Fix Version/s	3.1.4 [ 10500 ]

Paul Phillips made changes - 25/Jun/14 7:07 PM

Fix Version/s		3.2.2 [ 10505 ]
Fix Version/s	3.2.1 [ 10504 ]

Hide

Permalink

Cody Phillips (Inactive) added a comment - 28/Jul/14 6:25 PM

Tyson Phillips, any idea on how best to resolve this issue?

Could we simply add a line item for each service that the coupon applies to?

Obviously if the coupon is for a fixed amount, we'd need only a single line item for that fixed amount, but that becomes problematic when some of the services include tax and others do not.

Should we just maintain a separate calculation of the taxes applied to discounted services, then add that rate to the coupon total instead?

Show

Cody Phillips (Inactive) added a comment - 28/Jul/14 6:25 PM Tyson Phillips , any idea on how best to resolve this issue? Could we simply add a line item for each service that the coupon applies to? Obviously if the coupon is for a fixed amount, we'd need only a single line item for that fixed amount, but that becomes problematic when some of the services include tax and others do not. Should we just maintain a separate calculation of the taxes applied to discounted services, then add that rate to the coupon total instead?

Cody Phillips (Inactive) made changes - 28/Jul/14 6:35 PM

Description

A coupon line item from Services::buildServiceCouponLineItems() does not take into consideration whether or not tax should be applied to the discount. This results in line items having being taxed and the discount not removing any of the tax amount from the original line item. For example

Service - $100
Discount - 50%
Tax - 10%

Total should be $55, but is currently $60 because $100 + $100*0.1 - ($100*0.5) = $60

Instead it should be $100 + $100*.01 - ($100*0.5 + ($100*0.5*0.1)) = $55

The question is, how should taxes be handled in coupon line items? Should the line item be marked as taxable? If so, what about when there are multiple services, some taxable some not? Should we instead create a separate line item for each service? Should we calculate the tax and embed it into the line item (don't like that idea)?

A coupon line item from Services::buildServiceCouponLineItems() does not take into consideration whether or not tax should be applied to the discount. This results in line items having being taxed and the discount not removing any of the tax amount from the original line item. For example

Service - $100
Discount - 50%
Tax - 10%

Total should be $55, but is currently $60 because $100 + $100*0.1 - ($100*0.5) = $60

Instead it should be $100 + $100*.01 - ($100*0.5 + ($100*0.5*0.1)) = $55

The question is, how should taxes be handled in coupon line items? Should the line item be marked as taxable? If so, what about when there are multiple services, some taxable some not? Should we instead create a separate line item for each service? Should we calculate the tax and embed it into the line item (don't like that idea)?

*UPDATE*
Moved to feature request as some jurisdictions *require* tax on the full price before discounts.

This task must therefore also include an option to enable coupon tax (disabled by default to preserve current behavior).

Cody Phillips (Inactive) made changes - 28/Jul/14 6:35 PM

Issue Type

Bug [ 1 ]

New Feature [ 2 ]

Cody Phillips (Inactive) made changes - 28/Jul/14 6:35 PM

Fix Version/s		3.3.0 [ 10100 ]
Fix Version/s	3.2.2 [ 10505 ]

Cody Phillips (Inactive) made changes - 28/Jul/14 6:36 PM

Security

Private [ 10000 ]

Cody Phillips (Inactive) made changes - 28/Jul/14 6:36 PM

Summary

Coupon line items do not consider tax

Add option to calculate coupon discount with tax

Cody Phillips (Inactive) made changes - 28/Jul/14 6:37 PM

Description

A coupon line item from Services::buildServiceCouponLineItems() does not take into consideration whether or not tax should be applied to the discount. This results in line items having being taxed and the discount not removing any of the tax amount from the original line item. For example

Service - $100
Discount - 50%
Tax - 10%

Total should be $55, but is currently $60 because $100 + $100*0.1 - ($100*0.5) = $60

Instead it should be $100 + $100*.01 - ($100*0.5 + ($100*0.5*0.1)) = $55

The question is, how should taxes be handled in coupon line items? Should the line item be marked as taxable? If so, what about when there are multiple services, some taxable some not? Should we instead create a separate line item for each service? Should we calculate the tax and embed it into the line item (don't like that idea)?

*UPDATE*
Moved to feature request as some jurisdictions *require* tax on the full price before discounts.

This task must therefore also include an option to enable coupon tax (disabled by default to preserve current behavior).

A coupon line item from Services::buildServiceCouponLineItems() does not take into consideration whether or not tax should be applied to the discount. This results in line items having being taxed and the discount not removing any of the tax amount from the original line item. For example

Service - $100
Discount - 50%
Tax - 10%

Total should be $55, but is currently $60 because $100 + $100*0.1 - ($100*0.5) = $60

Instead it should be $100 + $100*.01 - ($100*0.5 + ($100*0.5*0.1)) = $55

The question is, how should taxes be handled in coupon line items? Should the line item be marked as taxable? If so, what about when there are multiple services, some taxable some not? Should we instead create a separate line item for each service? Should we calculate the tax and embed it into the line item (don't like that idea)?

*UPDATE*
Moved to feature request as some jurisdictions *require* tax on the full price before discounts.

This task must therefore also include a setting to discount tax with coupons (disabled by default to preserve current behavior of not discounting tax).

Hide

Permalink

Tyson Phillips (Inactive) added a comment - 29/Jul/14 1:21 PM

I'm thinking any tax discounted should be included in the coupon line item amount, i.e.:
"Should we just maintain a separate calculation of the taxes applied to discounted services, then add that rate to the coupon total instead?"

Show

Tyson Phillips (Inactive) added a comment - 29/Jul/14 1:21 PM I'm thinking any tax discounted should be included in the coupon line item amount, i.e.: "Should we just maintain a separate calculation of the taxes applied to discounted services, then add that rate to the coupon total instead?"

Paul Phillips made changes - 27/Aug/14 4:52 PM

Fix Version/s		3.3.0-b2 [ 10507 ]
Fix Version/s	3.3.0-b1 [ 10100 ]

Paul Phillips made changes - 15/Sep/14 12:11 PM

Fix Version/s		3.3.0 [ 10508 ]
Fix Version/s	3.3.0-b2 [ 10507 ]

Paul Phillips made changes - 24/Sep/14 4:48 PM

Fix Version/s		3.4.0 [ 10400 ]
Fix Version/s	3.3.0 [ 10508 ]

Paul Phillips made changes - 12/Dec/14 2:21 PM

Fix Version/s		3.5.0 [ 10401 ]
Fix Version/s	3.4.0-b1 [ 10400 ]

Paul Phillips made changes - 08/Apr/15 1:01 PM

Fix Version/s		3.5.0-b2 [ 10701 ]
Fix Version/s	3.5.0-b1 [ 10401 ]

Paul Phillips made changes - 08/Apr/15 4:02 PM

Fix Version/s

3.5.0-b2 [ 10701 ]

Cody Phillips (Inactive) made changes - 27/Oct/15 11:20 AM

Fix Version/s

4.0.0 [ 10603 ]

Cody Phillips (Inactive) made changes - 27/Oct/15 11:21 AM

Assignee

Cody Phillips [ cody ]

Tyson Phillips [ tyson ]

Hide

Permalink

Cody Phillips (Inactive) added a comment - 27/Oct/15 11:28 AM - edited

Tyson Phillips, I think our pricing library will let us handle this in an elegant way, right?

Show

Cody Phillips (Inactive) added a comment - 27/Oct/15 11:28 AM - edited Tyson Phillips , I think our pricing library will let us handle this in an elegant way, right?

Hide

Permalink

Tyson Phillips (Inactive) added a comment - 27/Oct/15 12:22 PM

Yeah, should be fine

Show

Tyson Phillips (Inactive) added a comment - 27/Oct/15 12:22 PM Yeah, should be fine

Cody Phillips (Inactive) made changes - 29/Oct/15 6:20 PM

Story Points

5

Paul Phillips made changes - 15/Sep/16 1:23 PM

Fix Version/s		4.0.0-b2 [ 11001 ]
Fix Version/s	4.0.0-b1 [ 10603 ]

Paul Phillips made changes - 20/Oct/16 1:57 PM

Fix Version/s		4.0.0-b3 [ 11002 ]
Fix Version/s	4.0.0-b2 [ 11001 ]

Paul Phillips made changes - 26/Oct/16 4:06 PM

Fix Version/s		4.0.0-b4 [ 11003 ]
Fix Version/s	4.0.0-b3 [ 11002 ]

Paul Phillips made changes - 07/Dec/16 4:35 PM

Fix Version/s		4.0.0-b5 [ 11004 ]
Fix Version/s	4.0.0-b4 [ 11003 ]

Paul Phillips made changes - 10/Feb/17 5:00 PM

Fix Version/s		4.0.0-b6 [ 11005 ]
Fix Version/s	4.0.0-b5 [ 11004 ]

Paul Phillips made changes - 03/Mar/17 4:24 PM

Fix Version/s		4.0.0-b7 [ 11009 ]
Fix Version/s	4.0.0-b6 [ 11005 ]

Paul Phillips made changes - 16/Mar/17 11:32 AM

Fix Version/s		4.1.0 [ 11007 ]
Fix Version/s	4.0.0 [ 11009 ]

Paul Phillips made changes - 18/Apr/17 4:00 PM

Fix Version/s		Short Term [ 10800 ]
Fix Version/s	4.1.0 [ 11007 ]

Paul Phillips made changes - 19/Jul/17 1:14 PM

Rank

Ranked higher

Tyson Phillips (Inactive) made changes - 29/Nov/17 5:02 PM

Rank

Ranked higher

Hide

Permalink

Paul Phillips added a comment - 03/Jan/19 2:28 PM

The Setting should be on the Package. Currently we have

[x] Taxable

If this is checked, then we can display a radio option below that says something like:

Apply Taxes after Discounts ( ) Apply Taxes before Discounts

By default, we should apply the taxes after discounts.

Show

Paul Phillips added a comment - 03/Jan/19 2:28 PM The Setting should be on the Package. Currently we have [x] Taxable If this is checked, then we can display a radio option below that says something like: Apply Taxes after Discounts ( ) Apply Taxes before Discounts By default, we should apply the taxes after discounts.

Hide

Permalink

Jonathan Reissmueller added a comment - 03/Jan/19 2:31 PM

In order to apply taxes to line items you can start by changing:

'tax' => false

to:

'tax' => true

In

app/models/invoices.php
app/controllers/admin_clients.php
app/controllers/client_services.php

Also to have the pricing presenter work this way add a company setting 'discount_taxes' to your database using a query like this:
INSERT INTO `company_settings` (`key`, `company_id`, `value`, `encrypted`, `inherit`) VALUES ('discount_taxes', '1', 'true', '0', '1');

Show

Jonathan Reissmueller added a comment - 03/Jan/19 2:31 PM In order to apply taxes to line items you can start by changing: 'tax' => false to: 'tax' => true In app/models/invoices.php app/controllers/admin_clients.php app/controllers/client_services.php Also to have the pricing presenter work this way add a company setting 'discount_taxes' to your database using a query like this: INSERT INTO `company_settings` (`key`, `company_id`, `value`, `encrypted`, `inherit`) VALUES ('discount_taxes', '1', 'true', '0', '1');

Paul Phillips made changes - 03/Jan/19 2:37 PM

Rank

Ranked higher

Add option to calculate coupon discount with tax

Details

Description

Activity

People

Dates

Agile