Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Duplicate
-
Affects Version/s: 3.6.0
-
Fix Version/s: 4.0.0-b1
-
Component/s: None
-
Labels:None
-
Environment:
emphasized text
Description
The method Services::getAllRenewablePaid is used by cron to fetch services that will then be renewed by contacting the module to renew them.
However, the current behavior of fetching the renewable paid services is to fetch all services that have ANY invoice paid since the last time it was checked. This is problematic, for instance, if someone buys and pays for a configurable option. The invoice for the configurable option will be paid, marking the invoice closed, and although there may be other open invoices for the service, it can be returned by Services::getAllRenewablePaid since there is a recent paid invoice.
The new behavior should be to only return services from Services::getAllRenewablePaid that have ALL of their active/proforma invoices closed, i.e., there are no open invoices for the service.
Issue Links
- duplicates
-
CORE-2167
Services may renew for paid invoices that are not necessarily for the renewal
-
- Closed
-
