Details
-
Type:
Task
-
Status: Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: 3.5.0-b2
-
Fix Version/s: 3.5.0-b3
-
Component/s: None
-
Labels:None
Description
On invoice line items, currently prorated credits are labeled as:
Prorated Removal
Instead that should read:
Prorated Credit
Secondly, services fail to show their label name when listed as Prorated Addition. For example:
Prorated Removal of VPS-1 (solus) - adsfasdf.google.com (May 13, 2015 - Jun 13, 2015)
Prorated Addition of VPS-1 (solus) (May 13, 2015 - Jun 13, 2015)
Instead it should be:
Prorated Removal of VPS-1 (solus) - adsfasdf.google.com (May 13, 2015 - Jun 13, 2015)
Prorated Addition of VPS-1 (solus) - adsfasdf.google.com (May 13, 2015 - Jun 13, 2015)
Activity
What if the service already exists (i.e. is not being changed)?
Cody Phillips (Inactive)
added a comment - What if the service already exists (i.e. is not being changed)? Something with the service is being changed, no? Otherwise there would be no upgrade, and no invoice created. We could re-use the old service name here, and it would likely be accurate most of the time, but since the module determines the field to use as the service name, it can choose one of the fields that has been changed, and it would not necessarily be the accurate service name after the service is upgraded.
Tyson Phillips (Inactive)
added a comment - Something with the service is being changed, no? Otherwise there would be no upgrade, and no invoice created. We could re-use the old service name here, and it would likely be accurate most of the time, but since the module determines the field to use as the service name, it can choose one of the fields that has been changed, and it would not necessarily be the accurate service name after the service is upgraded. Credit lines will say "Prorated Credit .." now.
The old service name will also be shown on the upgraded service line if one is available. The fact a service name could have changed during the upgrade can be dealt with in the future from another task if it becomes problematic to people.
Tyson Phillips (Inactive)
added a comment - Credit lines will say "Prorated Credit .." now.
The old service name will also be shown on the upgraded service line if one is available. The fact a service name could have changed during the upgrade can be dealt with in the future from another task if it becomes problematic to people. Awesome.
Cody Phillips (Inactive)
added a comment - Awesome. 
The service name is not known for new additions because it is determined by the module manager for a given service. Being that the addition is not yet a service, it cannot accurately be determined, and using the old service name may no longer be accurate once it is created.