Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-1738

Service override price validation can be ambiguous

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.0-b1
    • Fix Version/s: 3.5.1
    • Component/s: None
    • Labels:
      None

      Description

      When updating a service, validation occurs regarding override pricing and pricing changes. This occurs via Services::validatePricingWithOverrides.

      The idea is that if a pricing ID (term, package) has changed, then the service must not have any override pricing, or that override pricing must be removed at the same time.

      However, the validation rule defaults an override price to an empty string if it is not given, which purposefully does not pass validation. This allows for an error to be caused in legitimate cases, such as when a service does not have override pricing, and does not provide override pricing fields.

      This validation rule only applies when editing a service, so I think a possible solution is to replace the empty strings that are set by default with the actual service's override pricing.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            tyson Tyson Phillips (Inactive)
            Reporter:
            tyson Tyson Phillips (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jul/15