Details
Task
Description
See https://www.blesta.com/forums/index.php?/topic/9306-registering-plugin-action-widget_client_home/
I believe Blesta's expectation is that the plugin action contain a URI without query arguments. In some cases, Blesta may set it's own query arguments, and this can cause a conflict. Nonetheless we should look into why the error occurs and
- figure out why the issue occurs and update this task
- update the Blesta documentation to illustrate this expected restriction
- see if this restriction could be alleviated in the future to allow for query parameters (and if so, create a separate task)
Issue Links
- relates to
-
CORE-2439
Allow query parameters for plugin actions
-
- Closed
-
Activity
Tyson Phillips (Inactive)
created issue -
Tyson Phillips (Inactive)
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.1.0 Sprint 6 [ 43 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
| Assignee | Jonathan Reissmueller [ jonathan ] |
| Assignee | Jonathan Reissmueller [ jonathan ] |
| Assignee | Jonathan Reissmueller [ jonathan ] |
It would be the same for the admin widgets too then. I think you should update the documentation, where appropriate, to note that the URI should be only the path (relative to the base URI) that does not include any query or fragments. See https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Examples
Tyson Phillips (Inactive)
added a comment - It would be the same for the admin widgets too then. I think you should update the documentation, where appropriate, to note that the URI should be only the path (relative to the base URI) that does not include any query or fragments . See https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Examples Done. As for solutions, anything that limits the keys to characters that are valid in the jquery identifier should work fine. Hashing it was suggested in the forum post. You could also probably use a preg_replace to take care of non-valid characters.
Hashing it would probably work. Doing string replacements could cause collisions. Create a task to convert the ID to a hash for this purpose.
Tyson Phillips (Inactive)
added a comment - Hashing it would probably work. Doing string replacements could cause collisions. Create a task to convert the ID to a hash for this purpose. Tyson Phillips (Inactive)
made changes -
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Won't Fix [ 2 ] |
client_controller.php lines 98-101:
$key = str_replace('/', '_', trim($plugin->uri, '/')); $widgets[$key] = [ 'uri' => $this->base_uri . $plugin->uri ];This key is later used in jquery-client-4.1.0.js line 113:
$('#widget_container_' + this.widget_id).replaceWith(temp);This is where the error occurs because the the process for forming the key allows characters that are not legal for the jquery expression.