Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2439

Allow query parameters for plugin actions

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.0-b2
    • Fix Version/s: 4.2.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      client_controller.php lines 98-101:

      $key = str_replace('/', '_', trim($plugin->uri, '/'));
      $widgets[$key] = [
          'uri' => $this->base_uri . $plugin->uri
      ];
      

      This key is later used in jquery-client-4.1.0.js line 113:

      $('#widget_container_' + this.widget_id).replaceWith(temp);
      

      This is where the error occurs because the process for forming the key allows characters that are not legal for the jquery expression.

      Replace client_controller.php line 98 with:

      $key = $this->PluginManager->systemHash($plugin->uri);
      

      This will make a valid and unique key

        Issue Links

          Activity

          Hide
          tyson Tyson Phillips (Inactive) added a comment -

          You can use the system's hashing algorithm rather than directly using sha1 to avoid collisions.

          Show
          tyson Tyson Phillips (Inactive) added a comment - You can use the system's hashing algorithm rather than directly using sha1 to avoid collisions.
          Hide
          jonathan Jonathan Reissmueller added a comment -

          Widgets not properly set during initial login

          Show
          jonathan Jonathan Reissmueller added a comment - Widgets not properly set during initial login

            People

            • Assignee:
              jonathan Jonathan Reissmueller
              Reporter:
              jonathan Jonathan Reissmueller
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/17

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 1 hour, 54 minutes
                1d 1h 54m

                  Agile