Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 4.1.0-b2
-
Fix Version/s: 4.2.0-b1
-
Component/s: None
-
Labels:None
Description
client_controller.php lines 98-101:
$key = str_replace('/', '_', trim($plugin->uri, '/'));
$widgets[$key] = [
'uri' => $this->base_uri . $plugin->uri
];
This key is later used in jquery-client-4.1.0.js line 113:
$('#widget_container_' + this.widget_id).replaceWith(temp);
This is where the error occurs because the process for forming the key allows characters that are not legal for the jquery expression.
Replace client_controller.php line 98 with:
$key = $this->PluginManager->systemHash($plugin->uri);
This will make a valid and unique key
Issue Links
- relates to
-
CORE-2427 Look into possible issue with allowing plugin action query parameters
- Closed
You can use the system's hashing algorithm rather than directly using sha1 to avoid collisions.