[CORE-2439] Allow query parameters for plugin actions - Blesta

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.1.0-b2
Fix Version/s: 4.2.0-b1
Component/s: None
Labels:
None

Description

client_controller.php lines 98-101:

$key = str_replace('/', '_', trim($plugin->uri, '/'));
$widgets[$key] = [
    'uri' => $this->base_uri . $plugin->uri
];

This key is later used in jquery-client-4.1.0.js line 113:

$('#widget_container_' + this.widget_id).replaceWith(temp);

This is where the error occurs because the process for forming the key allows characters that are not legal for the jquery expression.

Replace client_controller.php line 98 with:

$key = $this->PluginManager->systemHash($plugin->uri);

This will make a valid and unique key

Issue Links

relates to

CORE-2427 Look into possible issue with allowing plugin action query parameters

Closed

Activity

Ascending order - Click to sort in descending order

Jonathan Reissmueller created issue - 04/Aug/17 11:14 AM

Jonathan Reissmueller made changes - 04/Aug/17 11:16 AM

Field	Original Value	New Value
Link		This issue relates to ~~CORE-2427~~ [ ~~CORE-2427~~ ]

Jonathan Reissmueller made changes - 04/Aug/17 11:17 AM

Fix Version/s		4.2.0-b1 [ 11014 ]
Fix Version/s	4.0.2 [ 11011 ]

Jonathan Reissmueller made changes - 04/Aug/17 11:35 AM

Rank

Ranked higher

Hide

Permalink

Tyson Phillips (Inactive) added a comment - 04/Aug/17 12:26 PM

You can use the system's hashing algorithm rather than directly using sha1 to avoid collisions.

Show

Tyson Phillips (Inactive) added a comment - 04/Aug/17 12:26 PM You can use the system's hashing algorithm rather than directly using sha1 to avoid collisions.

Jonathan Reissmueller made changes - 04/Aug/17 12:30 PM

Description

client_controller.php lines 98-101:

{code:java}
$key = str_replace('/', '_', trim($plugin->uri, '/'));
$widgets[$key] = [
'uri' => $this->base_uri . $plugin->uri
];
{code}

This key is later used in jquery-client-4.1.0.js line 113:

{code:java}
$('#widget_container_' + this.widget_id).replaceWith(temp);
{code}

This is where the error occurs because the the process for forming the key allows characters that are not legal for the jquery expression.

Replace client_controller.php line 98 with:

{code:java}
$key = sha1($plugin->uri);
{code}

This will make a valid and unique key

client_controller.php lines 98-101:

{code:java}
$key = str_replace('/', '_', trim($plugin->uri, '/'));
$widgets[$key] = [
'uri' => $this->base_uri . $plugin->uri
];
{code}

This key is later used in jquery-client-4.1.0.js line 113:

{code:java}
$('#widget_container_' + this.widget_id).replaceWith(temp);
{code}

This is where the error occurs because the the process for forming the key allows characters that are not legal for the jquery expression.

Replace client_controller.php line 98 with:

{code:java}
$key = $this->PluginManager->systemHash($plugin->uri);
{code}

This will make a valid and unique key

Tyson Phillips (Inactive) made changes - 31/Aug/17 7:25 PM

Story Points

Tyson Phillips (Inactive) made changes - 31/Aug/17 7:25 PM

Sprint

4.2.0 Sprint 1 [ 46 ]

Tyson Phillips (Inactive) made changes - 31/Aug/17 7:25 PM

Rank

Ranked lower

Tyson Phillips (Inactive) made changes - 18/Oct/17 1:57 PM

Sprint

4.2.0 Sprint 1 [ 46 ]

4.2.0 Sprint 1, 4.2.0 Sprint 2 [ 46, 47 ]

Tyson Phillips (Inactive) made changes - 18/Oct/17 1:57 PM

Rank

Ranked higher

Jonathan Reissmueller made changes - 26/Oct/17 11:59 AM

Description

client_controller.php lines 98-101:

{code:java}
$key = str_replace('/', '_', trim($plugin->uri, '/'));
$widgets[$key] = [
'uri' => $this->base_uri . $plugin->uri
];
{code}

This key is later used in jquery-client-4.1.0.js line 113:

{code:java}
$('#widget_container_' + this.widget_id).replaceWith(temp);
{code}

This is where the error occurs because the the process for forming the key allows characters that are not legal for the jquery expression.

Replace client_controller.php line 98 with:

{code:java}
$key = $this->PluginManager->systemHash($plugin->uri);
{code}

This will make a valid and unique key

client_controller.php lines 98-101:

{code:java}
$key = str_replace('/', '_', trim($plugin->uri, '/'));
$widgets[$key] = [
'uri' => $this->base_uri . $plugin->uri
];
{code}

This key is later used in jquery-client-4.1.0.js line 113:

{code:java}
$('#widget_container_' + this.widget_id).replaceWith(temp);
{code}

This is where the error occurs because the process for forming the key allows characters that are not legal for the jquery expression.

Replace client_controller.php line 98 with:

{code:java}
$key = $this->PluginManager->systemHash($plugin->uri);
{code}

This will make a valid and unique key

Automated transition triggered when Jonathan Reissmueller created a branch in Stash - 26/Oct/17 11:59 AM

Status

Open [ 1 ]

In Progress [ 3 ]

Jonathan Reissmueller made changes - 26/Oct/17 12:09 PM

Remaining Estimate		0 minutes [ 0 ]
Time Spent		10 minutes [ 600 ]
Worklog Id	10373 [ 10373 ]

Automated transition triggered when Jonathan Reissmueller created pull request #331 in Stash - 27/Oct/17 1:01 PM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Jonathan Reissmueller made changes - 31/Oct/17 1:34 PM

Time Spent	10 minutes [ 600 ]	49 minutes [ 2940 ]
Worklog Id	10394 [ 10394 ]

Jonathan Reissmueller made changes - 31/Oct/17 1:41 PM

Time Spent	49 minutes [ 2940 ]	1 hour, 9 minutes [ 4140 ]
Worklog Id	10395 [ 10395 ]

Jonathan Reissmueller made changes - 02/Nov/17 12:16 PM

Time Spent	1 hour, 9 minutes [ 4140 ]	2 hours, 9 minutes [ 7740 ]
Worklog Id	10406 [ 10406 ]

Jonathan Reissmueller made changes - 02/Nov/17 3:54 PM

Time Spent	2 hours, 9 minutes [ 7740 ]	4 hours, 16 minutes [ 15360 ]
Worklog Id	10407 [ 10407 ]

Jonathan Reissmueller made changes - 02/Nov/17 5:06 PM

Time Spent	4 hours, 16 minutes [ 15360 ]	4 hours, 46 minutes [ 17160 ]
Worklog Id	10408 [ 10408 ]

Tyson Phillips (Inactive) made changes - 03/Nov/17 2:58 PM

Sprint

4.2.0 Sprint 1, 4.2.0 Sprint 2 [ 46, 47 ]

4.2.0 Sprint 1, 4.2.0 Sprint 2, 4.2.0 Sprint 3 [ 46, 47, 48 ]

Tyson Phillips (Inactive) made changes - 03/Nov/17 2:58 PM

Rank

Ranked higher

Jonathan Reissmueller made changes - 09/Nov/17 11:23 AM

Time Spent	4 hours, 46 minutes [ 17160 ]	5 hours, 34 minutes [ 20040 ]
Worklog Id	10438 [ 10438 ]

Jonathan Reissmueller made changes - 10/Nov/17 1:10 PM

Time Spent	5 hours, 34 minutes [ 20040 ]	6 hours, 4 minutes [ 21840 ]
Worklog Id	10450 [ 10450 ]

Jonathan Reissmueller made changes - 14/Nov/17 7:19 PM

Time Spent	6 hours, 4 minutes [ 21840 ]	7 hours, 25 minutes [ 26700 ]
Worklog Id	10482 [ 10482 ]

Jonathan Reissmueller made changes - 15/Nov/17 12:01 PM

Time Spent	7 hours, 25 minutes [ 26700 ]	1 day, 1 minute [ 28860 ]
Worklog Id	10486 [ 10486 ]

Jonathan Reissmueller made changes - 16/Nov/17 11:23 AM

Time Spent	1 day, 1 minute [ 28860 ]	1 day, 1 hour, 1 minute [ 32460 ]
Worklog Id	10495 [ 10495 ]

Jonathan Reissmueller made changes - 16/Nov/17 11:59 AM

Time Spent	1 day, 1 hour, 1 minute [ 32460 ]	1 day, 1 hour, 34 minutes [ 34440 ]
Worklog Id	10496 [ 10496 ]

Automated transition triggered when Tyson Phillips (Inactive) merged pull request #331 in Stash - 16/Nov/17 7:34 PM

Status

In Review [ 5 ]

Closed [ 6 ]

Hide

Permalink

Jonathan Reissmueller added a comment - 27/Nov/17 1:02 PM

Widgets not properly set during initial login

Show

Jonathan Reissmueller added a comment - 27/Nov/17 1:02 PM Widgets not properly set during initial login

Jonathan Reissmueller made changes - 27/Nov/17 1:02 PM

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Reopened [ 4 ]

Automated transition triggered when Jonathan Reissmueller created a branch in Stash - 27/Nov/17 1:03 PM

Status

Reopened [ 4 ]

In Progress [ 3 ]

Automated transition triggered when Jonathan Reissmueller created pull request #360 in Stash - 27/Nov/17 1:05 PM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Jonathan Reissmueller made changes - 27/Nov/17 1:05 PM

Time Spent	1 day, 1 hour, 34 minutes [ 34440 ]	1 day, 1 hour, 54 minutes [ 35640 ]
Worklog Id	10541 [ 10541 ]

Automated transition triggered when Tyson Phillips (Inactive) merged pull request #360 in Stash - 28/Nov/17 6:21 PM

Status

In Review [ 5 ]

Closed [ 6 ]

People

Assignee:

Jonathan Reissmueller

Reporter:

Jonathan Reissmueller

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

04/Aug/17 11:14 AM

Updated:

28/Nov/17 6:21 PM

Resolved:

27/Nov/17 1:05 PM

Fix Release Date:

5/Dec/17

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1d 1h 54m

Agile

Completed Sprints:

4.2.0 Sprint 1 ended 18/Oct/17
4.2.0 Sprint 2 ended 03/Nov/17
4.2.0 Sprint 3 ended 29/Nov/17
View on Board