Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2493

Order: Signup may redirect to checkout when only registration order form exists

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Cannot Reproduce
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Someone reported @ https://www.blesta.com/forums/index.php?/topic/10591-user-signup-gives-error-no-input-file-specified/

      Apparently an error "No input file specified" can be encountered after someone signs up via a Registration order form, but no other order forms exist. The user identified this to be caused be the redirect in /order/controllers/signup.php:

      $this->redirect($this->base_uri . 'order/checkout/index/' . $this->order_form->label);
      

      Apparently redirecting to /order/checkout/index/ when no other order form exists can lead to this issue. We should attempt to duplicate and devise a solution.

        Activity

        Hide
        jonathan Jonathan Reissmueller added a comment -

        No luck recreating this yet, but from looking online it seems that this an environment issue. Is that even something we should worry about reproducing?

        Show
        jonathan Jonathan Reissmueller added a comment - No luck recreating this yet, but from looking online it seems that this an environment issue. Is that even something we should worry about reproducing?
        Hide
        tyson Tyson Phillips (Inactive) added a comment -

        What do you experience when that redirect occurs? And why do you think this is an environment issue?

        Show
        tyson Tyson Phillips (Inactive) added a comment - What do you experience when that redirect occurs? And why do you think this is an environment issue?
        Hide
        jonathan Jonathan Reissmueller added a comment -

        I just get sent back to the main portal page. It is not a message generated by us and looking online people say that it is environment. 'The No input file specified is a message you are presented with because of the implementation of PHP on your server, which in this case indicates a CGI implementation (can be verified with phpinfo()).' - stackoverflow

        Show
        jonathan Jonathan Reissmueller added a comment - I just get sent back to the main portal page. It is not a message generated by us and looking online people say that it is environment. 'The No input file specified is a message you are presented with because of the implementation of PHP on your server, which in this case indicates a CGI implementation (can be verified with phpinfo()).' - stackoverflow
        Hide
        tyson Tyson Phillips (Inactive) added a comment -

        II think the redirect would be best to go back to the main order page (if available, otherwise the portal page is fine).

        It seems to me the issue is that when there are no other order forms besides the register one, and after going through the process of registering, we redirect the user to order/checkout/index/, which is not a valid location. It may be at this point that the environment determines whether to display a message (e.g. missing file at that URL). However, we should make an effort to redirect to an appropriate location if we don't already. Does /order/checkout/index/ redirect itself if there is no matching order label?

        Show
        tyson Tyson Phillips (Inactive) added a comment - II think the redirect would be best to go back to the main order page (if available, otherwise the portal page is fine). It seems to me the issue is that when there are no other order forms besides the register one, and after going through the process of registering, we redirect the user to order/checkout/index/, which is not a valid location. It may be at this point that the environment determines whether to display a message (e.g. missing file at that URL). However, we should make an effort to redirect to an appropriate location if we don't already. Does /order/checkout/index/ redirect itself if there is no matching order label?
        Hide
        jonathan Jonathan Reissmueller added a comment -

        signup/index redirects to checkout/index on success, which redirects to main/index since there is an empty cart, which redirects to config/preconfig. That calls OrderTypeRegistration::handleRequest which redirects to the portal.

        Show
        jonathan Jonathan Reissmueller added a comment - signup/index redirects to checkout/index on success, which redirects to main/index since there is an empty cart, which redirects to config/preconfig. That calls OrderTypeRegistration::handleRequest which redirects to the portal.

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            tyson Tyson Phillips (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 1 hour, 46 minutes
              1h 46m

                Agile