Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2811

Invoices::getFromAutodebit does not check autodebit setting inheritance

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      The Invoices model, "getAutodebitDate" method runs a query to retrieve whether or not the client can be autodebited for the invoice, however, it requires that there exist the `client_settings`.`key` of "autodebit". Since the "autodebit" client setting is inherited, it may not be set, and should instead be observed from the client group/company setting from which it inherits.

      1. Update Invoices::getAutodebitDate to ensure that the check on the "autodebit" client setting also inherits from the client group/company settings as necessary
        • This will probably require a separate query to fetch the value of the client's autodebit setting
      2. Also check Invoices::getInvoices when fetching invoices "to_autodebit" or "pending_autodebit" since they also explicitly check the client setting

        Issue Links

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              jonathan Jonathan Reissmueller
              Reporter:
              tyson Tyson Phillips (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                31/Jan/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 14 minutes
                2h 14m

                  Agile