Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 4.5.0-b1
-
Component/s: None
-
Labels:None
Description
The Invoices model, "getAutodebitDate" method runs a query to retrieve whether or not the client can be autodebited for the invoice, however, it requires that there exist the `client_settings`.`key` of "autodebit". Since the "autodebit" client setting is inherited, it may not be set, and should instead be observed from the client group/company setting from which it inherits.
- Update Invoices::getAutodebitDate to ensure that the check on the "autodebit" client setting also inherits from the client group/company settings as necessary
- This will probably require a separate query to fetch the value of the client's autodebit setting
- Also check Invoices::getInvoices when fetching invoices "to_autodebit" or "pending_autodebit" since they also explicitly check the client setting
Issue Links
- is duplicated by
-
CORE-2981
Invoice Delivery (Unpaid) missing tag for autodebit_date_formatted
-
- Closed
-
Activity
Tyson Phillips (Inactive)
created issue -
Tyson Phillips (Inactive)
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.5.0 Sprint 1 [ 66 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked lower |
Tyson Phillips (Inactive)
made changes -
| Description |
The Invoices model, "getFromAutodebit" method runs a query to retrieve whether or not the client can be autodebited for the invoice, however, it requires that there exist the `client_settings`.`key` of "autodebit". Since the "autodebit" client setting is inherited, it may not be set, and should instead be observed from the client group/company setting from which it inherits.
# Update Invoices::getFromAutodebit to ensure that the check on the "autodebit" client setting also inherits from the client group/company settings as necessary #* This will probably require a separate query to fetch the value of the client's autodebit setting |
The Invoices model, "getAutodebitDate" method runs a query to retrieve whether or not the client can be autodebited for the invoice, however, it requires that there exist the `client_settings`.`key` of "autodebit". Since the "autodebit" client setting is inherited, it may not be set, and should instead be observed from the client group/company setting from which it inherits.
# Update Invoices::getAutodebitDate to ensure that the check on the "autodebit" client setting also inherits from the client group/company settings as necessary #* This will probably require a separate query to fetch the value of the client's autodebit setting # Also check Invoices::getInvoices when fetching invoices "to_autodebit" or "pending_autodebit" since they also explicitly check the client setting |
Tyson Phillips (Inactive)
made changes -
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 20 minutes [ 1200 ] | |
| Worklog Id | 11584 [ 11584 ] |
| Time Spent | 20 minutes [ 1200 ] | 1 hour, 57 minutes [ 7020 ] |
| Worklog Id | 11603 [ 11603 ] |
| Assignee | Jonathan Reissmueller [ jonathan ] |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Automated transition triggered when Jonathan Reissmueller created pull request #544 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | 4.5.0-b1 [ 11108 ] |
| Time Spent | 1 hour, 57 minutes [ 7020 ] | 2 hours, 14 minutes [ 8040 ] |
| Worklog Id | 11644 [ 11644 ] |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.5.0 Sprint 1 [ 66 ] | 4.5.0 Sprint 1, 4.5.0 Sprint 2 [ 66, 67 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #544 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
Tyson Phillips (Inactive)
made changes -
