Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-3019

When disabling a plugin, disable any of the plugins automation tasks also

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 4.5.0-b1
    • Fix Version/s: None
    • Component/s: Staff Interface
    • Labels:
      None

      Description

      When disabling a plugin that has automation tasks, those tasks are not disabled. Since the plugin is disabled, so should it's automation tasks. When re-enabling the plugin, re-enable its automation tasks.

      We will not know if the automation task was previously disabled prior to disabling the plugin, that's ok. Re-enabling a plugin should re-enable any of its automation tasks.

        Activity

        Hide
        tyson Tyson Phillips (Inactive) added a comment -

        Is this referring to the automation task being disabled in the UI under Settings > Automation? I'm not sure it makes sense to disable it here if the plugin is disabled. After all, someone could just re-enable the automation task even if the plugin is still disabled.

        When automation tasks are actually run by cron, plugin automation tasks are skipped if the plugin is disabled.

        Show
        tyson Tyson Phillips (Inactive) added a comment - Is this referring to the automation task being disabled in the UI under Settings > Automation? I'm not sure it makes sense to disable it here if the plugin is disabled. After all, someone could just re-enable the automation task even if the plugin is still disabled. When automation tasks are actually run by cron, plugin automation tasks are skipped if the plugin is disabled.
        Hide
        admin Paul Phillips added a comment -

        If the task isn't run when the plugin is disabled, then we probably shouldn't disable it here.. the last run date should be an indicator enough that it's not actually running because the plugin is disabled. So, if the plugin is disabled and no tasks will be run even if they exist and are enabled then we can probably ignore this.

        Show
        admin Paul Phillips added a comment - If the task isn't run when the plugin is disabled, then we probably shouldn't disable it here.. the last run date should be an indicator enough that it's not actually running because the plugin is disabled. So, if the plugin is disabled and no tasks will be run even if they exist and are enabled then we can probably ignore this.
        Hide
        tyson Tyson Phillips (Inactive) added a comment -

        The plugin automation tasks won't be run on a disabled plugin, so I'm going to close this task.

        In the future, we could update the Automation page to gray out the plugin's automation tasks if the plugin is disabled. This might give a better UX.

        Show
        tyson Tyson Phillips (Inactive) added a comment - The plugin automation tasks won't be run on a disabled plugin, so I'm going to close this task. In the future, we could update the Automation page to gray out the plugin's automation tasks if the plugin is disabled. This might give a better UX.

          People

          • Assignee:
            Unassigned
            Reporter:
            admin Paul Phillips
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: