Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-3078

Update extensions for php 7.2+ compatibility with Countable objects

    Details

    • Type: Story
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      Several modules/plugins call php's count() function, but it is not clear that it is always passed an iterable value to count. If it is not passed such a value (e.g. passed null or an empty string), then an error can be encountered in php 7.2+:

      count(): Parameter must be an array or an object that implements Countable on line ### in /app/components/modules/***/***.***
      

      This may be most prevalent in modules/plugins that call count and pass in a variable through _Html::ifSet _without specifying a default value, which means the default value is an empty string, thus encountering the error.

      It appears the following modules/plugins may need to be updated, at least to ensure a default value to count is provided.

      Modules

      1. Blesta License
      2. BuycPanel
      3. CentOS Web Panel
      4. CentovaCast
      5. CyberPanel
      6. DirectAdmin
      7. Enom
      8. GoGetSSL
      9. Interworx
      10. ISPConfig
      11. Logicboxes
      12. Multicraft
      13. Namecheap
      14. Plesk
      15. Proxmox
      16. SolusVM
      17. TCAdmin
      18. TeamSpeak
      19. Vesta
      20. Virtualmin
      21. VPS.net
      22. Vultr
      23. WHMSonic

      Plugins:

      1. FeedReader (views)
      2. Mass mailer (views)
      3. Order (views)
      There are no Sub-Tasks for this issue.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            tyson Tyson Phillips (Inactive)
            Reporter:
            tyson Tyson Phillips (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              28/May/19

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 3 hours, 26 minutes
              3h 26m

                Agile