Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7.0-b1
    • Component/s: Gateways
    • Labels:
      None

      Description

      green: complete
      yellow: skipped, not entirely necessary

      Preliminary testing of the Stripe Payments brought up the following issues:

      1. On the Gateway listing page
        • The Stripe logo should differ from the old logo, maybe say "Stripe Payments"
        • There is a line that reads "Supports..." and lists the name of the interfaces implemented by the gateway, but the CCForm interface has no name
      2. When managing the gateway:
        • Attempting to save without entering credentials will say the system could not connect to the "Stipe" gateway (i.e. spelling error, missing "r").
        • Check all locations where "Stipe" is written, I think there is more than one
      3. Admin UI Payment accounts
        • When adding/editing a payment account, the customer's name/address is not provided to stripe, so the "Customers" section of the Stripe dashboard displays blank rows. We should be able to include the name and address info
        • When editing a payment account you have to enter the card details again. There should probably be an option to skip updating the card details altogether in order to keep whatever already exists
          • This may not be necessary immediately, but we should consider allowing support for it in the future by updating the Payments::getBuildCcForm and GatewayPayments::getBuildCcForm and making them accept additional information on the $contact_info and $options that may be set such that the gateway that generates the form can make that distinction in some way
        • When editing a payment account to change the card number or the expiration date, an error in Blesta occurs regarding an "Invalid card type" being provided. This was handled for adding and should be handled appropriately here for editing too. (Note: the card does get updated in Stripe)
        • When editing a payment account to enter the same card number and expiration date, an error in Blesta occurs, "An error occured when processing the request with the gateway." This is because a new card was added to Stripe and the old card could not be removed: "The payment method you provided is not attached to a customer so detachment is impossible."
        • Deleting a payment account does not delete the payment account in Stripe. I still see it under the Customer
      4. Admin UI Make Payment
        • When making a payment via "Make Payment" in the admin UI, the payment may fail due to a Stripe error:

          The provided PaymentMethod was previously used with a PaymentIntent without being attached to a Customer or was detached from a Customer. It may not be used again. To use a PaymentMethod multiple times, you must attach it to a Customer first.

          This appears to be caused by updating the payment account. If I attempt the payment after I have gone to edit the payment account to change the card number/etc. then go to make a payment as an admin, I am not prompted for the 3ds check, but instead, the error occurs on submit.

        • When making a payment via "Make Payment" in the admin UI, selecting 1 invoice to pay when there are multiple in the list, then paying it, will cause ALL invoices in the list to be sent to Stripe as the "Description" for the payment. The description should instead only be the 1 invoice being paid, not all of them. Note, this works correctly in the client UI
        • When making a payment via "Make Payment" in the admin UI that requires 3ds, but 3ds fails, a new payment cannot be reattempted. Attempting to do so results in a Stripe HTTP 400 error:

          message: A card payment method was expected to be present, but this PaymentIntent does not have a payment method and none was provided. Try again with a payment method or card data.

        • Additionally, if attempting to click the "Edit Payment", the system does not take you back to the previous step to change the payment. instead, it submits the current payment to Stripe.
        • When making a payment and choosing to enter new card details, but NOT saving the account:
          • The Confirm Payment page shows payment details reading, "Credit Card () ending in". It is missing the card type and card last 4.
          • Blesta shows a success message reading

            The payment was successfully processed for $1.07 USD. Transaction Number:

            That is, there is no transaction number.
          • In Stripe, the payment is shown as "Incomplete", which is likely the reason there is no transaction number. Why was it approved in Blesta?

      Client UI:

      1. Using "Make Payment" and paying only an "Other Amount" (not an invoice) the description in stripe reads just "Charge for". It may be better to say it was a "Charge for specified amount".
      2. Using "Make Payment" and entering New Payment details for a new credit card, if "Save Account" is NOT checked, then the customer is unable to continue. Note this was tested with a card required 3ds. The following errors occur:

        Please enter the credit card expiration date.
        The expiration date has already lapsed.
        The card type is invalid or could not be determined.

        Issue Links

          Activity

          Hide
          tyson Tyson Phillips (Inactive) added a comment -

          Things to consider for the future:

          • allowing multiple payments simultaneously in different tabs for the same session (currently limited to 1 payment per session)
          • see if we can move error messages from underneath the card to instead trigger a redirect to step 1 of the payment process and display the error in a normal red message box
          Show
          tyson Tyson Phillips (Inactive) added a comment - Things to consider for the future: allowing multiple payments simultaneously in different tabs for the same session (currently limited to 1 payment per session) see if we can move error messages from underneath the card to instead trigger a redirect to step 1 of the payment process and display the error in a normal red message box

            People

            • Assignee:
              tyson Tyson Phillips (Inactive)
              Reporter:
              tyson Tyson Phillips (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Sep/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 4 hours, 59 minutes
                1d 4h 59m

                  Agile