Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      Right now themes define a logo using an absolute URL in a text field. I think we should keep this option but also allow users to upload a logo for the theme.

      Logo mimetypes should be limited based on a config value and the file should be renamed (something along the lines of theme_logo_[Theme ID]).

      We should add a method to the Uploads controller called theme() that will be very similar to the invoices method. It should expect $this->get[0] to be 'logo' and should stream the image for the current theme.

      We currently have an invoice logo upload under Billing/Payment > Invoice Customization

        Activity

        Hide
        admin Paul Phillips added a comment -

        Would the logo be uploaded under the theme edit screen? We don't allow the default theme to be edited. Perhaps we should make a change to the default theme.. allow the theme to be edited, but ONLY allow a logo to be uploaded, or a logo URL to be set. Add an info box stating that editing the default theme is not allowed and it should be exported and imported as a new theme. This is a question that comes up often, and it may be a good opportunity to make a change along with the logo upload option. Just a though, obviously we should create a different task if that sounds good.

        Show
        admin Paul Phillips added a comment - Would the logo be uploaded under the theme edit screen? We don't allow the default theme to be edited. Perhaps we should make a change to the default theme.. allow the theme to be edited, but ONLY allow a logo to be uploaded, or a logo URL to be set. Add an info box stating that editing the default theme is not allowed and it should be exported and imported as a new theme. This is a question that comes up often, and it may be a good opportunity to make a change along with the logo upload option. Just a though, obviously we should create a different task if that sounds good.

          People

          • Assignee:
            abdy Abdy Franco
            Reporter:
            jonathan Jonathan Reissmueller
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              23/Dec/20

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 4 days, 5 hours, 48 minutes
              4d 5h 48m

                Agile