Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.0.0-b1
-
Component/s: None
-
Labels:None
Description
Right now themes define a logo using an absolute URL in a text field. I think we should keep this option but also allow users to upload a logo for the theme.
Logo mimetypes should be limited based on a config value and the file should be renamed (something along the lines of theme_logo_[Theme ID]).
We should add a method to the Uploads controller called theme() that will be very similar to the invoices method. It should expect $this->get[0] to be 'logo' and should stream the image for the current theme.
We currently have an invoice logo upload under Billing/Payment > Invoice Customization
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Story Points | 3 |
| Sprint | 5.0.0 Sprint 4 [ 121 ] |
| Rank | Ranked lower |
| Fix Version/s | 5.0.0-b1 [ 11107 ] |
| Sprint | 5.0.0 Sprint 4 [ 121 ] | 5.0.0 Sprint 5 [ 122 ] |
| Rank | Ranked lower |
| Assignee | Abdy Franco [ abdy ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 3 hours, 44 minutes [ 13440 ] | |
| Worklog Id | 14589 [ 14589 ] |
| Time Spent | 3 hours, 44 minutes [ 13440 ] | 1 day, 3 hours, 42 minutes [ 42120 ] |
| Worklog Id | 14590 [ 14590 ] |
| Time Spent | 1 day, 3 hours, 42 minutes [ 42120 ] | 2 days, 3 hours, 30 minutes [ 70200 ] |
| Worklog Id | 14591 [ 14591 ] |
| Sprint | 5.0.0 Sprint 5 [ 122 ] | 5.0.0 Sprint 6 [ 123 ] |
| Rank | Ranked lower |
| Time Spent | 2 days, 3 hours, 30 minutes [ 70200 ] | 3 days, 3 hours, 31 minutes [ 99060 ] |
| Worklog Id | 14592 [ 14592 ] |
| Time Spent | 3 days, 3 hours, 31 minutes [ 99060 ] | 3 days, 6 hours, 38 minutes [ 110280 ] |
| Worklog Id | 14595 [ 14595 ] |
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Time Spent | 3 days, 6 hours, 38 minutes [ 110280 ] | 3 days, 7 hours, 17 minutes [ 112620 ] |
| Worklog Id | 14601 [ 14601 ] |
| Time Spent | 3 days, 7 hours, 17 minutes [ 112620 ] | 4 days, 2 minutes [ 115320 ] |
| Worklog Id | 14602 [ 14602 ] |
| Time Spent | 4 days, 2 minutes [ 115320 ] | 4 days, 1 hour, 59 minutes [ 122340 ] |
| Worklog Id | 14616 [ 14616 ] |
| Time Spent | 4 days, 1 hour, 59 minutes [ 122340 ] | 4 days, 3 hours, 43 minutes [ 128580 ] |
| Worklog Id | 14617 [ 14617 ] |
| Time Spent | 4 days, 3 hours, 43 minutes [ 128580 ] | 4 days, 4 hours, 26 minutes [ 131160 ] |
| Worklog Id | 14618 [ 14618 ] |
| Time Spent | 4 days, 4 hours, 26 minutes [ 131160 ] | 4 days, 5 hours, 48 minutes [ 136080 ] |
| Worklog Id | 14619 [ 14619 ] |
| Status | In Review [ 5 ] | Closed [ 6 ] |
Would the logo be uploaded under the theme edit screen? We don't allow the default theme to be edited. Perhaps we should make a change to the default theme.. allow the theme to be edited, but ONLY allow a logo to be uploaded, or a logo URL to be set. Add an info box stating that editing the default theme is not allowed and it should be exported and imported as a new theme. This is a question that comes up often, and it may be a good opportunity to make a change along with the logo upload option. Just a though, obviously we should create a different task if that sounds good.