Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.0.0
-
Component/s: None
-
Labels:None
Description
We had a beta tester encounter an issue on upgrade where they had records in the `plugin_actions` table with no matching record in the `plugins` table. The migration still attempted to convert these actions but was unable to do so. We use a left join:
leftJoin('plugins', 'plugins.id', '=', 'plugin_actions.plugin_id', false)->
which allows these records to be considered. Instead we should use an inner join
innerJoin('plugins', 'plugins.id', '=', 'plugin_actions.plugin_id', false)->
so they will be ignored.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Sprint | 5.0.0b2 Sprint 1 [ 124 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Sprint | 5.0.0b2 Sprint 1 [ 124 ] |
| Rank | Ranked lower |
| Story Points | 1 |
| Sprint | 5.0.0b2 Sprint 1 [ 124 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Rank | Ranked lower |
| Assignee | Jonathan Reissmueller [ jonathan ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 7 minutes [ 420 ] | |
| Worklog Id | 14665 [ 14665 ] |
| Status | In Review [ 5 ] | Closed [ 6 ] |
