Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.0.0
-
Component/s: None
-
Labels:None
Description
We had a beta tester encounter an issue on upgrade where they had records in the `plugin_actions` table with no matching record in the `plugins` table. The migration still attempted to convert these actions but was unable to do so. We use a left join:
leftJoin('plugins', 'plugins.id', '=', 'plugin_actions.plugin_id', false)->
which allows these records to be considered. Instead we should use an inner join
innerJoin('plugins', 'plugins.id', '=', 'plugin_actions.plugin_id', false)->
so they will be ignored.
