Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.4.0-b2
-
Component/s: None
-
Labels:None
Description
A user reported errors installing Blesta on PHP 8.1.
Installing via web the receive the attached error.
Installing via cli they receive this error:
./index.php install PHP Deprecated: Return type of Pimple\Container::offsetExists($id) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/blesta/vendors/pimple/pimple/src/Pimple/Container.php on line 133 PHP Deprecated: Return type of Pimple\Container::offsetGet($id) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/blesta/vendors/pimple/pimple/src/Pimple/Container.php on line 98 PHP Deprecated: Return type of Pimple\Container::offsetSet($id, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/blesta/vendors/pimple/pimple/src/Pimple/Container.php on line 79 PHP Deprecated: Return type of Pimple\Container::offsetUnset($id) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/blesta/vendors/pimple/pimple/src/Pimple/Container.php on line 143 ---------------------------------------- Blesta CLI Installer ---------------------------------------- Please acknowledge your agreement to the terms and conditions as explained at
Activity
Alright, this opens up a larger issue of PHP compatibility in downstream dependencies. In this instance phillipsdata/minphp-container is the library that requires pimple/pimple and the version of pimple that supports php 8 has a minimum requirement of php 7.2, which is incompatible with the minimum requirement of php 5.6 declared by phillipsdata/minphp-container.
For now, let's side step the issue by disabling error_reporting in init.php. In 5.5 I think we'll want to introduce updates to any blesta or phillipsdata libraries to have a minimum requirement of php 7.2 so that we don't encounter downstream dependency issues like this.
I was able to solve the first error just by running composer install, Pimple was updated to support PHP 8.1 and apparently updating the dependency is enough to solve the issue. The second error was fixed on this PR: https://github.com/phillipsdata/minphp-record/pull/9