Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 5.5.0
-
Fix Version/s: 5.7.0-b1
-
Component/s: Plugins, Staff Interface
-
Labels:None
Description
I ran across an issue where trying to order a domain would wipe the domain from the cart after doing an availability check, and trying to add to cart and continue. The issue was related to the order form label being called: "Register Domains ". Note the space between Register and Domains, and the space after Domains. I believe the trailing space caused the issue.
It's not a great idea to use spaces in the label, and it caused an issue in that case. I suggest that we do validation on the label field when creating an order form to ensure that we allow only:
a-z
A-Z
0-9
-_
If there are any other safe characters we can allow, then we may allow them also.
When editing an order form, skip the validation IF the label is not being changed. So if someone has a space in their label now and needs to update their order form but isn't changing the label, we want to let them keep the label. We don't want to force them to change the URL that is already in use, linked to from their website, indexed by Google, etc.
