Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-5248

Support Manager: Custom fields disabled on PHP 8.2 and 8.3

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.10.2
    • Fix Version/s: 5.11.0-b3
    • Component/s: Plugins
    • Labels:
      None

      Description

      On PHP 8.2 and 8.3, clients see custom fields as disabled even if client can add is enabled.

      Create text field, all 3 options enabled.

      Login as client try to create ticket, note field is disabled.

        Activity

        admin Paul Phillips created issue -
        admin Paul Phillips made changes -
        Field Original Value New Value
        Attachment screenshot-1.png [ 13007 ]
        admin Paul Phillips made changes -
        Attachment screenshot-2.png [ 13008 ]
        admin Paul Phillips made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        admin Paul Phillips made changes -
        Summary Support Manager: Custom fields disabled on PHP 8.3 Support Manager: Custom fields disabled on PHP 8.2 and 8.3
        admin Paul Phillips made changes -
        Description On PHP 8.3, clients see custom fields as disabled even if client can add is enabled.

        Create text field, all 3 options enabled.

        Login as client try to create ticket, note field is disabled.
        On PHP 8.2 and 8.3, clients see custom fields as disabled even if client can add is enabled.

        Create text field, all 3 options enabled.

        Login as client try to create ticket, note field is disabled.
        Hide
        admin Paul Phillips added a comment -

        To fix- In plugins/support_manager/controllers/client_tickets.php around line 788 change

                    if ($field->client_add !== 1 || ($field->client_add == 1 && !empty($vars[$field->id]))) {
                        $disabled = ['disabled' => 'disabled'];
                    }
        

        To:

                    if ($field->client_add != 1 || ($field->client_add == 1 && !empty($vars[$field->id]))) {
                        $disabled = ['disabled' => 'disabled'];
                    }
        
        Show
        admin Paul Phillips added a comment - To fix- In plugins/support_manager/controllers/client_tickets.php around line 788 change if ($field->client_add !== 1 || ($field->client_add == 1 && !empty($vars[$field->id]))) { $disabled = ['disabled' => 'disabled']; } To: if ($field->client_add != 1 || ($field->client_add == 1 && !empty($vars[$field->id]))) { $disabled = ['disabled' => 'disabled']; }
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.11.0 Sprint 6 [ 206 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.11.0 Sprint 6 [ 206 ] 5.11.0 Sprint 6, 5.11.0 Sprint 7 [ 206, 207 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.11.0 Sprint 6, 5.11.0 Sprint 7 [ 206, 207 ] 5.11.0 Sprint 6, 5.11.0 Sprint 7, 5.12.0 Sprint 1 [ 206, 207, 208 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        jonathan Jonathan Reissmueller made changes -
        Status Open [ 1 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        abdy Abdy Franco made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 15 minutes [ 900 ]
        Worklog Id 17521 [ 17521 ]
        jonathan Jonathan Reissmueller made changes -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            admin Paul Phillips
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              21/Jan/25

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 15 minutes
              15m

                Agile