Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-5345

Logicboxes: Replace field domain-name with domain so that it is the same as all other registrars

    Details

    • Type: Improvement
    • Status: In Progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 5.11.0-b3
    • Fix Version/s: 5.12.0-b1
    • Labels:
      None

      Description

      I believe the standard field name for domain registrar modules is to use "domain" for the domain name. Logicboxes uses domain-name instead. This causes a few problems, but the primary is that it is impossible to add the domain as an admin.

      If you add a domain using the [+] add domain option in the domains widget using Logicboxes, when you get to the final step you will receive an error: Required parameter missing: domain-name

      I believe this is because the search box on the 1st step, which checks domain availability for register or transfer, so by the final step we don't have domain-name, we have domain.

      I think we should update the domain-name field to domain so that it is consistent and to resolve the above issue. The question is how do we deal with existing domains that use the domain-name field?

      Do we:

      • Run a migration and replace all service fields in the database with a key of domain-name with domain?
      • Do we add an exception when fetching the domain to fall back to domain-name? Essentially, if domain does not exist, $domain = $domain-name.

      Or do we do both?

        Activity

        Hide
        admin Paul Phillips added a comment -

        We should make sure to submit a PR for this to https://github.com/blesta/module-logicboxes also since we are moving this there in 5.12

        Show
        admin Paul Phillips added a comment - We should make sure to submit a PR for this to https://github.com/blesta/module-logicboxes also since we are moving this there in 5.12

          People

          • Assignee:
            abdy Abdy Franco
            Reporter:
            admin Paul Phillips
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 6 hours, 27 minutes
              6h 27m

                Agile