Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.12.3
-
Component/s: None
-
Labels:None
Description
To reproduce
1. Get a client with no payment account (or autodebit disabled)
2. Create a domain assigned to that client (make sure the renewal price is non-zero) - Note the expiration date
3. Make sure that the initial invoice is paid
4. Edit the domain as a service
5. Change the renewal date to tomorrow
6. Process the cron manually
7. See that the service is renewed and the domain sync is run
8. See that the expiration date is not changed
To fix:
1. Update the once daily version to get only domains with an expiration date within "domains_renewal_days_before_expiration" (labeled as Renew Days Before Expiration in the domain settings page)
2. Update the regular version to be based on when the renewal was actually done. To track this lets add a column to the domains_domains table for awaiting_sync or renewal_unsync'd or something